New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in convert_screen_to_ndc in pytorch3d convention. #365

Open

Darius-H opened this issue Jul 19, 2023 · 0 comments

Darius-H commented Jul 19, 2023

I find that when using pytorch3d, convert_screen_to_ndc function does not work properly, it generates a wrong principal point.
The convert_screen_to_ndc is here: https://github.com/open-mmlab/mmhuman3d/blob/9431addec32f7fbeffa1786927a854c0ab79d9ea/mmhuman3d/core/conventions/cameras/convert_convention.py#L481C1-L481C1
I find that in pytorch3d’s code , there is a principal point fix matrix, which is not included in mmhuman's code:
https://github.com/facebookresearch/pytorch3d/blob/57f6e79280e78b6e8308f750e64d32984ddeaba4/pytorch3d/renderer/cameras.py#L1187C1-L1224C1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment