Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make bubble gradient toggleable #68

Open
sabogalc opened this issue Jul 18, 2021 · 3 comments
Open

[Feature Request] Make bubble gradient toggleable #68

sabogalc opened this issue Jul 18, 2021 · 3 comments

Comments

@sabogalc
Copy link

My reasoning for this is that on longer messages, the bottom of the bubble is a very light blue color, and since the text color is white, it can be hard on the eyes and difficult to read. The way I solved this for my personal copy was by setting from-me in _colors.scss to #0E85FF. Then, I changed --bubble-background in IMChatItem.scss from imessage-gradient to from-me. The reason I haven't made a pull request for this is because I want the option to be toggleable.
Below are some screenshots of how the gradient looks vs. how my implementation of a solid colored bubble works (note, I don't have an SMS enabled device, so I'm not sure how to deal with this for SMS or iMessage Business).
Light Mode Gradient
Light Mode Solid
Dark Mode Gradient
Dark Mode Solid
and below is a screenshot of this toggle in the BlueBubbles Desktop App
Settings Page
Along with the gradient vs. solid color comparison in BlueBubbles
BlueBubbles Gradient
BlueBubbles Solid
One thing I was worried about with making the bubbles solid blue was that it might make it difficult to see the blue highlight when selecting text, but thankfully the #0E85FF color does not cause this issue in my opinion. I think it is also a good color for the send button and the tapback bubble background, though come to think of it, maybe I should close that pull request and also make it toggleable. Let me know your thoughts.

@sabogalc
Copy link
Author

In an effort to use a less random and more Apple approved shade of blue, I grabbed this screenshot from my Mac. To my eye, it looked like there was no gradient on either one of the blues (message bubble and tapback bubble)
Screen Shot 2021-07-29 at 10 56 30 AM
I then went to this website to check what the exact shade of blue was, but I learned that there was a slight gradient. On the message bubble, the G and B values appeared to be within 111-113 and 226-229 respectively, while the R value appeared to be anywhere between 2-6.
image
I just figured I'd leave my findings here.

@sabogalc
Copy link
Author

These two screenshots came from my iPad in another effort to get the blue as close to Apple's as possible.
IMG_0443
IMG_0439
Thankfully, this blue has no gradient on it, so it is the same color at all points in the circle. I found that it was #0B84FE
image
This shade of blue works out well, and it doesn't prevent the highlight/select text from being seen
image

@EricRabil
Copy link
Member

I have not forgotten you! I will take a look at this and others next week. Thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants