Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return proper error message in PATCH /orgs/{orgid}/users/{username} when no valid attributes are specified #626

Open
ewee33 opened this issue Jun 22, 2022 · 0 comments
Open

Return proper error message in PATCH /orgs/{orgid}/users/{username} when no valid attributes are specified #626

ewee33 opened this issue Jun 22, 2022 · 0 comments
Labels
bug

Comments

@ewee33
Copy link
Contributor

ewee33 commented Jun 22, 2022

In this route, a check is done to see if no valid attributes were specified. If so, it attempts to return code 400 BAD INPUT with an associated error message. However, there are two problems:

  • The return statement is improperly formatted, causing no return to actually occur and execution of the route to continue.
  • The error message provided is incorrect, referencing an agbot rather than a user
@ewee33 ewee33 self-assigned this Jun 22, 2022
@ewee33 ewee33 added the bug label Jun 22, 2022
ewee33 added a commit to ewee33/exchange-api that referenced this issue Jun 27, 2022
@ewee33
Issue open-horizon#626: PATCH /orgs/{orgid}/users/{username} now retu…
3b20d71 
…rns the proper error message when no attributes are specified

Signed-off-by: Ethan Weaver <emw0022@mix.wvu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ewee33