Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/home/wumao/opencompass-main/opencompass/summarizers/needlebench.py 的sizes是不是少了一个128k [Bug] [Feature] #1132

Closed
1 task done
1518630367 opened this issue May 10, 2024 · 1 comment · Fixed by #1143
Assignees

Comments

@1518630367
Copy link

Describe the feature

导致报错:
Traceback (most recent call last):
File "/home/wumao/opencompass-main/run.py", line 4, in
main()
File "/home/wumao/opencompass-main/opencompass/cli/main.py", line 354, in main
summarizer.summarize(time_str=cfg_time_str)
File "/home/wumao/opencompass-main/opencompass/summarizers/needlebench.py", line 540, in summarize
save_results_to_plots(output_path)
File "/home/wumao/opencompass-main/opencompass/summarizers/needlebench.py", line 215, in save_results_to_plots
folder_path = os.path.join(plot_path, dataset_mapping_dict[dataset_abbr])
KeyError: '2needle_en_128k'

Will you implement it?

  • I would like to implement this feature and create a PR!
@DseidLi
Copy link
Collaborator

DseidLi commented May 12, 2024

Thank you for your careful attention to this matter! I have updated the code accordingly in #1143.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants