Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-correct when check_data applies shifts from 0 and 1 #93

Open
beckyfisher opened this issue Nov 12, 2021 · 2 comments
Open

Auto-correct when check_data applies shifts from 0 and 1 #93

beckyfisher opened this issue Nov 12, 2021 · 2 comments

Comments

@beckyfisher
Copy link
Collaborator

The check_data function will apply a shift to ether the x or y data under certain scenarios. Ideally predicted values (and associated NEC, NSEC and ECx estimates) should be corrected for this shift before being returned.

@beckyfisher
Copy link
Collaborator Author

Note this might be tricky for NEC as it is a returned parameter, not a predicted value.

@beckyfisher
Copy link
Collaborator Author

beckyfisher commented Nov 12, 2021

An alternative to providing corrected values would be to simply add the applied correction as an attribute to the bayesnecfit or bayesmanecfit object.

Note also that this is only important for adjustments to x, as these impact the endpoint estimates when they are near zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant