Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Op refs to directories missing an op.yml aren't caught as data resolution errors #896

Open
chrisdostert opened this issue Mar 19, 2021 · 1 comment
Labels
bug Incorrect behavior which hasn't been released

Comments

@chrisdostert
Copy link
Contributor

chrisdostert commented Mar 19, 2021

馃悰 Bug Report

When I opctl run notAnOp and notAnOp is a valid directory but has no op.yml, I don't get a fancy error.

To Reproduce

  1. Create a directory at ./.opspec/notAnOp
  2. Run opctl run notAnOp

Expected behavior

fancy error:

unable to resolve op 'notAnOp': 
- filesystem: 
  - path [omitted]/.opspec/notAnOp/op.yml not found
  - path [omitted]/notAnOp/op.yml not found
- opctl node: unable to resolve op 'notAnOp': 
  - filesystem: skipped
  - git: invalid git ref: missing version

Actual Behavior

open /Users/chrisdostert/repos/github.com/opctl/opctl/cli/.opspec/test/op.yml: no such file or directory
@chrisdostert chrisdostert added the bug Incorrect behavior which hasn't been released label Mar 19, 2021
@chrisdostert
Copy link
Contributor Author

chrisdostert commented Mar 19, 2021

@apexskier maybe you'd be interested/willing to take on

@apexskier apexskier changed the title Fancy resolution error not working when valid dir but not valid op (no op.yml) Op refs to directories missing an op.yml aren't caught as data resolution errors Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior which hasn't been released
Projects
None yet
Development

No branches or pull requests

1 participant