Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@nano-sql/adapter-rocksdb needs rocksdb@^4.0.0 for NodeJS v12 #200

Open
wanseob opened this issue Apr 18, 2020 · 1 comment
Open

@nano-sql/adapter-rocksdb needs rocksdb@^4.0.0 for NodeJS v12 #200

wanseob opened this issue Apr 18, 2020 · 1 comment

Comments

@wanseob
Copy link

wanseob commented Apr 18, 2020

Which version are you using?

NodeJS: v12

"@nano-sql/adapter-rocksdb": "^2.0.7"

Describe the bug

It is not possible to use @nano-sql/adapter-rocksdb with Node v12. It is maybe because nodev12 needs rocksdb v4 but this package has a dependency of a lower version.

make: *** [leveldown.target.mk:121: Release/obj.target/leveldown/src/batch.o] Error 1
make: Leaving directory '/home/~/node-gyp-test/node_modules/@nano-sql/adapter-rocksdb/node_modules/rocksdb/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/~/.nvm/versions/node/v12.16.2/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:310:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Linux 5.3.0-46-generic
gyp ERR! command "/home/~/.nvm/versions/node/v12.16.2/bin/node" "/home/~/.nvm/versions/node/v12.16.2/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/~/node-gyp-test/node_modules/@nano-sql/adapter-rocksdb/node_modules/rocksdb
gyp ERR! node -v v12.16.2
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
npm WARN gyp-test@1.0.0 No description
npm WARN gyp-test@1.0.0 No repository field.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! rocksdb@3.1.0 install: `prebuild-install || node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the rocksdb@3.1.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/~/.npm/_logs/2020-04-18T22_45_02_384Z-debug.log

Expected behavior
Successful install without error

Example

nvm install v12
nvm use v12
mkdir testdir && cd testdir
npm init
npm install --save @nano-sql/adapter-rocksdb
@wanseob
Copy link
Author

wanseob commented Apr 18, 2020

Please see this thread
Level/rocksdb#118 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant