Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize flow.json loading behaviour #562

Open
jribbink opened this issue Mar 21, 2024 · 0 comments
Open

Synchronize flow.json loading behaviour #562

jribbink opened this issue Mar 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jribbink
Copy link
Contributor

Currenty, when the flow.json is initially loaded by the LS, the LS will crash if the file is invalid. However, if changes to flow.json cause a request to the LS to reload the file, then the LS will not crash but rather ignore the reloaded file & continue to use the old one. This behaviour needs to be synchronized, as it could become somewhat unclear why the user's LS diagnostics don't line up with their flow.json file, not realizing that it is due to some error.

It may be part of a more general issue that, maybe, invalid flow.json should not be a fatal error at all & the file could just be ignored?

@jribbink jribbink added the bug Something isn't working label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🧊 Backlog
Development

No branches or pull requests

1 participant