Addon is unusable with Ember 2.15 #239

onechiporenko · 2017-08-19T14:48:59Z

steverhoades · 2017-09-02T17:52:22Z

@onechiporenko I just attempted to upgrade to 2.15 and see why this issue was created.

Do you know what in 2.15 broke this add-on? I'd like to help if possible but at the moment there isn't a clear error indicating where this add-on is failing.

What I am seeing is empty rows in the table and an error being thrown on click.

ember-metal.js:3988 TypeError: Cannot read property 'get' of undefined
    at Class.onRowSelect (route.js:171)
    at Router$1.triggerEvent (router.js:1017)
    at trigger (router.js:111)
    at Router$1.trigger (router.js:1699)
    at Class.send (router.js:327)
    at Class.send (action_handler.js:42)
    at Class.triggerAction (target_action_support.js:89)
    at Class.sendAction (action_support.js:115)
    at Class.clickOnRow (component.js:44)
    at Class.send (action_support.js:129)

steverhoades · 2017-09-03T18:41:29Z

@onechiporenko Adding the following issue so it can be tracked. I believe this is related to the breakage of this add-on in 2.15.

emberjs/ember.js#15621

onechiporenko · 2017-09-04T14:06:48Z

Hi, @steverhoades. Something become broken with partials on Ember-2.15. Since Ember core-devs recommended to not use partials and move to the contextual components I have to do this too. Branch v2.0 (https://github.com/onechiporenko/ember-models-table/tree/v2.0) contains new version of ember-models-table. It's not published yet, but i'm working on it.

mydea · 2017-09-04T14:23:22Z

I now it is still WIP, but may I recommend that you nest the components? I think that would make it easier to grasp & to override it.

E.g.:

components/models-table.js
components/models-table/select.js
components/models-table/footer.js
components/models-table/row.js
...

You can use these nested components normally in the template, e.g. {{models-table/row}}.

onechiporenko · 2017-09-04T14:41:59Z

@mydea, thanks. I think I'll do as you said. It's a good idea!
2.0 is big major release with great changes, so fill free to propose/ask/recommend :)

mydea · 2017-09-04T14:47:12Z

Awesome! Is there a place for recommendations etc, or should I just put them here?
I would also be up to help out if there is anything you'd need help with - ember-models-table is an integral part of our products, so I'm happy to give back :)

onechiporenko · 2017-09-04T14:57:53Z

Yes, you may put it here.

I would also be up to help out if there is anything you'd need help with

Thanks! For now I need a "fresh outlook" (IDK, if it's a correct translation from "свежий взгляд со стороны").

"Coding part" contains next items:

Refactor existing tests (use ember-cli-mirage and ember-cli-page-object)
Add MORE tests (and for server-paginated table too)
Change components nesting
Allow to send actions from anywhere in the component to the outer context
Check performance
Create separated demos for v1.13 and v2.0
~~Take over the world~~

onechiporenko · 2017-09-04T15:01:35Z

ember-models-table is an integral part of our products, so I'm happy to give back :)

I'm really glad that ember-models-table is useful for your products :)

Ramblurr · 2017-09-05T14:07:35Z

The discussion here has left me a little confused. Glad to see 2.0 is coming along :-D

But, is version 1.x going to be updated to support Ember >= 2.15?

onechiporenko · 2017-09-06T13:45:12Z

@Ramblurr, upgrading 1.x means that some partials (IDK all partials or only a part of them) should be combined into one template.
As for now, it's not a problem with addon itself. Yes, I've used not best practice with partials instead of components, but partials are supported currently and are not deprecated officially. Some error happens with Ember (or Glimmer or any other lib). I believe that bug emberjs/ember.js#15621 will be fixed and v1.x will continue work correctly.

Ramblurr · 2017-09-08T08:57:09Z

Good to hear! I didn't realize this was caused by a bug in Ember rather than a deprecation/change. Thanks @onechiporenko

onechiporenko · 2017-09-11T11:01:12Z

v2.0.0-alpha.1 is released. It's a pre-release for anyone who wants to test new design and help to improve it.

Run ember ember-cli-yuidoc to build docs-dir

majesticblvd · 2017-09-11T21:17:32Z

Hey, first of all thanks for a great addon! When using Ember 2.15 with v2.0.0-alpha.1 branch, the column template functionality is not working (the cells are now blank). propertyName cells are still showing up correctly.

Keep up the good work!

onechiporenko · 2017-09-12T06:13:29Z

@DennisNygren, main idea for version 2.* is replace templates (partials) with contextual and "normal" components. So, upgrade to version 2.* requires refactoring. Some migration docs will be prepared later. For now - just replace partials with components.

onechiporenko · 2017-09-12T15:52:03Z

v2.0.0-beta.1 is released.

majesticblvd · 2017-09-12T17:18:20Z

@onechiporenko Ok thanks for your quick reply!

arnebit · 2017-09-21T09:45:53Z

Great work so far!

Is there a particular reason not to pass table=this to a componentForFilterCell anymore?

That used to be the case before and I relied on it (on accessing processedColumns in particular) to implement filter options dependent on another filter (subcategory <- main category).

onechiporenko · 2017-09-21T10:44:52Z

@arnebit, componentForFilterCell receives several properties (see https://github.com/onechiporenko/ember-models-table/blob/v2.0/addon/templates/components/models-table/row-filtering.hbs#L16). Let me know if something more is needed.

Passing table=this is a bad practice that I shouldn't use before (but I did 😢)

onechiporenko · 2017-09-22T09:20:00Z

v2.0.0-beta.2 is released.

cmonzon44 · 2017-09-24T02:18:38Z

Separated issue is created
#254

===========
edited by @onechiporenko

arnebit · 2017-09-25T14:31:49Z

@onechiporenko Why is passing table=this bad? Because it would give the user...flexibility? ;-)

The aforementioned processedColumns aside, looking for table. in my project, I find I am also accessing/using

the sort action and
filteredContent,
to implement a "toggle flag on all visible items" (to solve a problem similar to Select only filtered data #214, it seems).

onechiporenko · 2017-09-27T12:09:06Z

Check new demo page for v.2 http://onechiporenko.github.io/ember-models-table/v.2/

onechiporenko · 2017-09-27T14:06:50Z

v2.0.0-beta.3 is released.

GSakunthala · 2017-09-28T12:07:05Z

I am using ember-model-table 2.0beta after the issue came up with "partials" in ember 2.15.I want to know if there is an option to customize the pagination in 2.0 such as "componentFooterTemplate" in 1.0? Pls help as it affects my app in production.

onechiporenko · 2017-09-28T12:29:11Z

@SakuDivya, sure. You may override models-table/footer or use block content like:

{{#models-table data=data columns=columns as |mt|}}
  {{#mt.footer as |footer|}}
    {{! custom markup here }}
  {{/mt.footer}}
{{/models-table}}

onechiporenko · 2017-09-28T12:32:28Z

Short diff-manual for migration from 1.x to 2.x is here - en/ru

GSakunthala · 2017-09-28T12:48:43Z

Thanks for the quick reply. But if want pagination functionalities and only need to change the UI lookup of page numbers,what needs to be done.Do i have to write a separate component and write all functionalities instead of {{footer.pagination-numeric}} ?

onechiporenko · 2017-09-28T12:56:21Z

@SakuDivya, pls create a separated issue. This one is like a "news-board" for 2.x.

GSakunthala · 2017-09-28T13:19:50Z

I have created.Pls take a look Thank u...

onechiporenko · 2017-10-04T15:25:18Z

v2.0.0-beta.4 is released. Check small theming guide en / ru

steverhoades · 2017-10-04T20:09:42Z

Looking really good, thanks for all the hard work @onechiporenko !

onechiporenko · 2017-10-12T15:19:38Z

v2.0.0 is released.

onechiporenko self-assigned this Aug 19, 2017

mydea mentioned this issue Sep 5, 2017

Move to nested component structure #242

Merged

onechiporenko added the v2.* label Sep 6, 2017

onechiporenko mentioned this issue Sep 21, 2017

Is column.template available in v2? #252

Closed

onechiporenko closed this as completed Oct 12, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addon is unusable with Ember 2.15 #239

Addon is unusable with Ember 2.15 #239

onechiporenko commented Aug 19, 2017 •

edited

steverhoades commented Sep 2, 2017

steverhoades commented Sep 3, 2017

onechiporenko commented Sep 4, 2017

mydea commented Sep 4, 2017

onechiporenko commented Sep 4, 2017

mydea commented Sep 4, 2017

onechiporenko commented Sep 4, 2017 •

edited

onechiporenko commented Sep 4, 2017 •

edited

Ramblurr commented Sep 5, 2017

onechiporenko commented Sep 6, 2017

Ramblurr commented Sep 8, 2017

onechiporenko commented Sep 11, 2017 •

edited

majesticblvd commented Sep 11, 2017

onechiporenko commented Sep 12, 2017

onechiporenko commented Sep 12, 2017

majesticblvd commented Sep 12, 2017

arnebit commented Sep 21, 2017 •

edited

onechiporenko commented Sep 21, 2017

onechiporenko commented Sep 22, 2017

cmonzon44 commented Sep 24, 2017 •

edited by onechiporenko

arnebit commented Sep 25, 2017

onechiporenko commented Sep 27, 2017

onechiporenko commented Sep 27, 2017

GSakunthala commented Sep 28, 2017

onechiporenko commented Sep 28, 2017

onechiporenko commented Sep 28, 2017 •

edited

GSakunthala commented Sep 28, 2017

onechiporenko commented Sep 28, 2017

GSakunthala commented Sep 28, 2017

onechiporenko commented Oct 4, 2017

steverhoades commented Oct 4, 2017

onechiporenko commented Oct 12, 2017

Addon is unusable with Ember 2.15 #239

Addon is unusable with Ember 2.15 #239

Comments

onechiporenko commented Aug 19, 2017 • edited

steverhoades commented Sep 2, 2017

steverhoades commented Sep 3, 2017

onechiporenko commented Sep 4, 2017

mydea commented Sep 4, 2017

onechiporenko commented Sep 4, 2017

mydea commented Sep 4, 2017

onechiporenko commented Sep 4, 2017 • edited

onechiporenko commented Sep 4, 2017 • edited

Ramblurr commented Sep 5, 2017

onechiporenko commented Sep 6, 2017

Ramblurr commented Sep 8, 2017

onechiporenko commented Sep 11, 2017 • edited

majesticblvd commented Sep 11, 2017

onechiporenko commented Sep 12, 2017

onechiporenko commented Sep 12, 2017

majesticblvd commented Sep 12, 2017

arnebit commented Sep 21, 2017 • edited

onechiporenko commented Sep 21, 2017

onechiporenko commented Sep 22, 2017

cmonzon44 commented Sep 24, 2017 • edited by onechiporenko

arnebit commented Sep 25, 2017

onechiporenko commented Sep 27, 2017

onechiporenko commented Sep 27, 2017

GSakunthala commented Sep 28, 2017

onechiporenko commented Sep 28, 2017

onechiporenko commented Sep 28, 2017 • edited

GSakunthala commented Sep 28, 2017

onechiporenko commented Sep 28, 2017

GSakunthala commented Sep 28, 2017

onechiporenko commented Oct 4, 2017

steverhoades commented Oct 4, 2017

onechiporenko commented Oct 12, 2017

onechiporenko commented Aug 19, 2017 •

edited

onechiporenko commented Sep 4, 2017 •

edited

onechiporenko commented Sep 4, 2017 •

edited

onechiporenko commented Sep 11, 2017 •

edited

arnebit commented Sep 21, 2017 •

edited

cmonzon44 commented Sep 24, 2017 •

edited by onechiporenko

onechiporenko commented Sep 28, 2017 •

edited