Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use sycl::detail namespace #401

Open
AlexeySachkov opened this issue Oct 23, 2023 · 2 comments
Open

Don't use sycl::detail namespace #401

AlexeySachkov opened this issue Oct 23, 2023 · 2 comments
Assignees

Comments

@AlexeySachkov
Copy link

sycl::detail::pi is used in:

sycl::detail::pi::contextSetExtendedDeleter(*placedContext_, ContextCallback,

Please note there detail sub-namespace is reserved for implementations and there is no guarantees about its content. Not only that is non-portable, but it is also unmaintainable, because there is always risk that internal implementation details will change tomorrow.

@andrewtbarker
Copy link
Contributor

@AlexeySachkov Thank you for reporting this. Do you have a suggestion for how to accomplish what we are doing here in some other way?

@AlexeySachkov
Copy link
Author

Hi @andrewtbarker, unfortunately I don't see any core or an extension-provided feature which would expose the same functionality. Therefore, it seems to me that you may need to request a corresponding extension to be added to have this API formalized - this won't be portable still, but at least it would not be relying on implementation details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants