Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_shuffle fails on aarch64 when BF16 data type is enabled. #1806

Closed
renato-arantes opened this issue Feb 15, 2024 · 3 comments · Fixed by #1907
Closed

test_shuffle fails on aarch64 when BF16 data type is enabled. #1806

renato-arantes opened this issue Feb 15, 2024 · 3 comments · Fixed by #1907
Assignees
Labels
bug A confirmed library bug platform:aarch64

Comments

@renato-arantes
Copy link
Contributor

renato-arantes commented Feb 15, 2024

Summary

By enabling BF16 data type on aarch64 here, test_shuffle fails here.

Version

main, commit 0c2ea8b by @kawakami-k

Steps to reproduce

The code here checks if ACL is present. But the issue also happens without ACL. By replacing the lines 120 and 121 with:

#elif DNNL_AARCH64
            return true;

Someone can enable BF16 on aarch64 by default, and reproduce the issue without ACL.

@renato-arantes renato-arantes added the sighting Suspicious library behavior. Should be promoted to a bug when confirmed label Feb 15, 2024
@kawakami-k
Copy link
Contributor

Hi, @renato-arantes

I reproduced test_shuffle of 67012a5 on Ubuntu22.04 AWS Graviton3.

.github/automation/build_acl.sh  --version 23.11 --arch armv8a --multi_isa --root-dir $(pwd)/ComputeLibrary
.github/automation/build.sh --threading omp --mode Release --source-dir $(pwd) --build-dir $(pwd)/build --acl-dir $(pwd)/ComputeLibrary
cd build/tests/gtests
./test_shuffle --gtest_filter="ShuffleSimpleBF16/shuffle_test_t.TestsShuffle/4"

This error message is as same as yours?

Note: Google Test filter = ShuffleSimpleBF16/shuffle_test_t.TestsShuffle/4:-*_GPU*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from ShuffleSimpleBF16/shuffle_test_t
[ RUN      ] ShuffleSimpleBF16/shuffle_test_t.TestsShuffle/4
free(): invalid pointer
zsh: abort (core dumped)  ./test_shuffle 

@renato-arantes
Copy link
Contributor Author

Hi @kawakami-k,

Sorry for the delay in responding to you.

It is similar:

./test_shuffle --gtest_filter="ShuffleSimpleBF16/shuffle_test_t.TestsShuffle/4"

Note: Google Test filter = ShuffleSimpleBF16/shuffle_test_t.TestsShuffle/4:-*_GPU*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from ShuffleSimpleBF16/shuffle_test_t
[ RUN      ] ShuffleSimpleBF16/shuffle_test_t.TestsShuffle/4
test_shuffle: /home/renara01/desenv/oncpuml_1480/github/oneDNN/src/cpu/aarch64/shuffle/jit_uni_shuffle_kernel.cpp:77: void dnnl::impl::cpu::aarch64::jit_uni_shuffle_kernel_t<isa>::gather_data(const Xbyak_aarch64::XReg&, int, int, bool) [with dnnl::impl::cpu::aarch64::cpu_isa_t isa = dnnl::impl::cpu::aarch64::sve_256]: Assertion `!"unsupported emu_gather_data"' failed.
Aborted (core dumped)

@vpirogov vpirogov added bug A confirmed library bug platform:aarch64 and removed sighting Suspicious library behavior. Should be promoted to a bug when confirmed labels Mar 27, 2024
@kawakami-k
Copy link
Contributor

I'll fix the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed library bug platform:aarch64
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants