Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature proposal: logging only mailer #29

Open
JASchilz opened this issue Dec 28, 2017 · 3 comments
Open

Feature proposal: logging only mailer #29

JASchilz opened this issue Dec 28, 2017 · 3 comments

Comments

@JASchilz
Copy link

For debugging and development purposes, it would be helpful for me to have a mailer which does not send any emails. Instead, it would implement only the logging features of a mailer. The calling code could provide this mailer a logger which logs to the console, or to a file, etc.

I would propose to call this mailer class NoMail, implementing the MailerInterface. Per your spec, it would log emails at info level.

If you concur, I'll submit a pull request. Otherwise, please close. (:

@JASchilz JASchilz changed the title Feature proposal: NoMail or logging only emailer Feature proposal: logging only mailer Dec 28, 2017
@gabrielbull
Copy link
Collaborator

Sounds like a good idea. If you have time to create a PR I would accept it.

@JASchilz
Copy link
Author

On it. It might be another month.

@shahariaazam
Copy link
Collaborator

I think if we can resolve #2 that will help this too.

@shahariaazam shahariaazam added this to the Next Release (v1.0.0) milestone Aug 18, 2020
@shahariaazam shahariaazam added feature-requests New feature requests testing labels Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants