-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package installation #57
Comments
List of all dependencies (from DESCRIIPTION). Add checkmark if they are on bioconda: Imports:
Suggests:
Python dependencies
|
lol, do I get that right that bseqsc and scbio are the only unpatched deconvolution dependencies? @PelzKo, could you please add all python dependencies to that list? |
MuSiC is also unpatched, IF they accept my pullrequest (to allow a single bulk data sample to be used). But yes, otherwise thats true... Which makes our package quite helpful I think.
Done |
Thanks! List of patches:
In summary, I think Bioconda could be feasible. The patches for missing dependencies are irrelevant for bioconda, |
@PelzKo, could you please link all the upstream issues/PRs in this thread just to keep an overview... |
Merged ones will be striked through
Python dependencies
|
I had another go at the bioconda recipes... but maybe we should just release a docker container and be done with it. |
I think I figured out MOMF. This leaves only two problematic PRs: csSAM and SCDC. Conda-forge has a different build system in general, and uses @PelzKo, do you still have capacity to try this in the next weeks? |
Yeah I can do that. Thanks for your work with MOMF! |
I just checked again, and conda-forge won't work because both packages have
dependencies that are only on bioconda (bioconductor-...) 😅
…On Tue, 7 Dec 2021 at 04:35, Konstantin Pelz ***@***.***> wrote:
I think I figured out MOMF.
This leaves only two problematic PRs: csSAM and SCDC. I don't have the
foggiest how to solve the environment not resolving on the bioconda CI, but
I'd suggest to try moving those two packages to conda-forge.
Conda-forge has a different build system in general, and uses mamba
instead of conda since a few weeks, so we have better chances.
@PelzKo <https://github.com/PelzKo>, do you still have capacity to try
this in the next weeks?
Yeah I can do that. Thanks for your work with MOMF!
I will try to do csSAM and SCDC next week
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVZRVZT23YH4SH2LJ7SJSLUPV6GXANCNFSM46FVY4DA>
.
|
Love it... What would you suggest? Should I try tagging the core team again or is there another developer who could look it over? Unfortunately it is the first time I'm working with conda, bioconda and conda-forge, so I am not sure of how much help I can be |
Ok, I got them all in! Next step would be building the actual omnideconv package. We can try locally with |
Now that the repo is public, we need to create a bioconda recipe for |
Maybe not relevant yet, but I wanted to put some thoughts on this together.
Omnideconv has quite complex dependencies (R packages, python, and docker(/podman/singularity), so we need to make sure it is still easy to install. In principle, there are three installation routes:
1. Plain R package
(CRAN/Bioconductor won't be an option, as too many dependencies are not available there)
This will only install R packages, so we need to address python and docker.
2. Bioconda
This will install both R and python packages. There is no need to use basilisk or reticulate to install packages.
The challenge here is that some of our dependencies are not available from bioconda (those in the
Remotes
section). We willneed to contribute those packages to bioconda before adding our package. I had to do the same for immunedeconv.
3. Container
# this should start an R shell with omnideconv available podman run -it quay.io/biocontainers/r-omnideconv R
As soon as omnideconv is on bioconda, we get a container for free from Biocontainers :).
The question is how to run cibersort in that case. Maybe docker in docker (dind) could work.
It may be that we need to manually extend the container from Biocontainers for that.
The text was updated successfully, but these errors were encountered: