Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tag feature : Adding colors #483

Open
Rdornier opened this issue Jun 26, 2023 · 2 comments
Open

New Tag feature : Adding colors #483

Rdornier opened this issue Jun 26, 2023 · 2 comments

Comments

@Rdornier
Copy link

Having different colors for tags could be a very good option to make the webclient more user-friendly (like in Trello cards).
The colors could visually differenciate processes, categories, workflows... For example, blue tags could refer to the biological sample, green ones to the microscope acquisition and orange ones to proessing.

Forum thread : https://forum.image.sc/t/omero-tags-queries/82584

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omero-tags-queries/82584/4

@will-moore
Copy link
Member

Items of work (if we decide to use LongAnnotations on a Tag to store a colour value)

  • Need some way to add a colour annotation to a Tag and make sure only 1 is added. This could be done in the right panel when the Tag is selected, since that will allow updating of the colour after creation. Users might expect to be able to do this in the Tag creation dialog but that will make the dialog more complex and the API end-points for Tag creation (which are already a bit complex with tags to add and remove) will also have to include colour for new Tags. So, simpler to only support editing of colour after creation. This will need a new URL endpoint. The Colour Annotations will need a custom namespace to indicate that they are "Colour annotations". Although OMERO permissions allow anyone in a read-annotate group to add Annotations to other's data, it might make sense to restrict this to the owner of the Tag.

  • When tags are loaded and we want to show colours, we'll also need to load the Colour annotations:

    • When loading Tags for right panel, which uses /webclient/api/annotations/?type=tag&image=1. This loads the Tags via
      def api_annotations(request, conn=None, **kwargs):
      and
      select oal from %sAnnotationLink as oal
      . That query will need another join/fetch etc to load Colour Annotations if we are loading Tags (but not when loading other annotations)
    • When loading Tags for the Tree (left panel). That is loaded with e.g. /webclient/api/tags/?orphaned=true&experimenter_id=-1 but uses the same OMERO query function as above.
    • Possibly also in the Tagging dialog.
    • When we are filtering a Dataset by Tag - uses same URL endpoint as for right panel
  • Maybe also in tagsearch and autotag plugins? cc @Tom-TBT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants