Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify supported URLs protocol in the image key for masks #57

Open
sbesson opened this issue Jul 17, 2020 · 0 comments
Open

Clarify supported URLs protocol in the image key for masks #57

sbesson opened this issue Jul 17, 2020 · 0 comments
Assignees
@manics
Projects
OME Zarr Masks (Summer 2020)

Comments

@sbesson
Copy link
Member

sbesson commented Jul 17, 2020

https://github.com/ome/omero-ms-zarr/blob/v0.1.6/spec.md#image includes two conventions for the value of the array key: either a relative path or an URL.

While the first convention was implementated and tested by omero-cli-zarr, it is unclear which URL protocols are expected to be supported. The specification document uses an example with the https protocol while the current omero-cli-zarr implementation uses an omero protocol - see https://github.com/ome/omero-cli-zarr/blob/313af34d151b824426f7f009dbfce833d2aee25c/src/omero_zarr/masks.py#L168-L171 Are other valid procotols like s3 also supported?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manics manics

Labels
None yet
Projects
OME Zarr Masks (Summer 2020)
  
Review in progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix masks.[].image.array to match spec manics-archive/omero-cli-zarr
2 participants
@sbesson @manics