Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseOptions strips characters after "]" #4127

Open
CFGrote opened this issue Dec 8, 2023 · 3 comments
Open

parseOptions strips characters after "]" #4127

CFGrote opened this issue Dec 8, 2023 · 3 comments

Comments

@CFGrote
Copy link

CFGrote commented Dec 8, 2023

Bioformats version 7.0.1

This bug report is related to ImageSc post https://forum.image.sc/t/omero-fiji-plugin-error-invalid-image-id/89470/11.

In brief, the fiji-omero plugin reports an error (loci.formats.FormatException: Invalid image ID) when opening an image from our institute's omero. this issue was observed by some users but not by all.

Attaching jdb to a running Fiji process, I narrowed it down to the following:

Stopping in bioformats' loci.plugins.in.Importer.parseOptions(), line 127

print arg

"location=[OMERO] open=[omero:server=ome.evolbio.mpg.de
user=grotec
port=4064
pass=XXXXX]YYYYYYY
groupID=3
iid=36540] view=Hyperstack windowless=false crop=false "

Note the password: It has a "]", likely closing the opening "[" after "open=".

Then, in line 132:

print options.getId()

options.getId() = "omero:server=ome.evolbio.mpg.de
user=grotec
port=4064
pass=XXXXX"

So somewhere in between, everything after the "]" in my password must have been stripped away,
including the Image ID, causing the exception in the Fiji plugin.

I hope this can be fixed.

Something else that strikes me is that passwords seem to be passed as plain text, but is this really necessary?
Shouldn't the image id be all that is needed to query the image and send it to Fiji?
But maybe there are other use cases where this information is actually needed.

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omero-fiji-plugin-error-invalid-image-id/89470/12

@joshmoore
Copy link
Member

Oh wow 👏🏽

@dominikl
Copy link
Member

Thank you very much @CFGrote . I'm surprised that this is handed down to and fails at the Bioformats level, as all the authentication and transfer is done on the OMERO level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants