Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont check for update if FormatTools.VERSION is "(unknown version)" #4118

Open
CGDogan opened this issue Nov 22, 2023 · 2 comments
Open

Dont check for update if FormatTools.VERSION is "(unknown version)" #4118

CGDogan opened this issue Nov 22, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@CGDogan
Copy link
Contributor

CGDogan commented Nov 22, 2023

Sometimes version string is unknown version

. in this case, print a debug log statement here that cannot check update because dont know version and don't make a request that will otherwise fail and print a verbose error

@sbesson
Copy link
Member

sbesson commented Nov 22, 2023

On the principle, I agree the upgrade checker could handle the cases where FormatTools.VERSION is set to its fallback value and return early for instance.

Trying to understand the context, can you elaborate on the scenario you are trying to address here? FormatTools.VERSION should only be set to (unknown version) if the metadata cannot be found in the JAR manifest and should never happen with release versions.

@sbesson sbesson added the question Further information is requested label Nov 22, 2023
@CGDogan
Copy link
Contributor Author

CGDogan commented Nov 23, 2023

Sorry I was indeed referring to development versions - it would help save bandwidth but as you said I have never seen it happen with release versions. So this is a really, really minor issue.

@sbesson sbesson added enhancement New feature or request and removed question Further information is requested labels Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants