Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs of flags only with numeric #683

Open
BaseHardware opened this issue Mar 30, 2024 · 0 comments
Open

Bugs of flags only with numeric #683

BaseHardware opened this issue Mar 30, 2024 · 0 comments

Comments

@BaseHardware
Copy link

If I give a flag only with numeric as follows, FuseSoC fails to parse the core files.

targets:
  default:
    flags:
      blah: 1234

The problem is that it crashes without any proper messages but only with interpreting error messages from python3 as follows:

  File "/home/aaaa/.local/lib/python3.12/site-packages/fusesoc/capi2/exprs.py", line 202, in expand
    flag_defs = Exprs._flags_to_flag_defs(flags)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aaaa/.local/lib/python3.12/site-packages/fusesoc/capi2/exprs.py", line 194, in _flags_to_flag_defs
    ret.append(k + "_" + v)
               ~~~~~~~~^~~
TypeError: can only concatenate str (not "int") to str

Please fix this bug. I think replacing ret.append(k + "_" + v) to ret.append(k + "_" + str(v)) is enough to fix this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant