Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inherited scripts are overwritten #646

Open
GCHQDeveloper211 opened this issue Sep 7, 2023 · 1 comment
Open

inherited scripts are overwritten #646

GCHQDeveloper211 opened this issue Sep 7, 2023 · 1 comment

Comments

@GCHQDeveloper211
Copy link

It seems that if you have a core file that creates a post_build hook with a script, lets say FOO. If you coincidentally create a post_build hook and script also called FOO, either by inheriting from another core file or creating it in the core file in question, this will create a makefile with several targets all with the same name, and hence only the latter target will be run.
since this is done in the make file, is it worth having fusesoc embed a part of the VLNV or some sort of identifier to ensure that all the hook targets are unique?

@olofk
Copy link
Owner

olofk commented Sep 13, 2023

Yes, some kind of protection is apparently needed. And if I understand correcty the fix needs to bee on the FuseSoC side. Patches welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants