Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to git 2.17 breaks a little #120

Open
slackhead opened this issue Apr 12, 2018 · 3 comments
Open

Update to git 2.17 breaks a little #120

slackhead opened this issue Apr 12, 2018 · 3 comments

Comments

@slackhead
Copy link

The error message that is printed when not in a git repo has changed from:

fatal: Not a git repository to
fatal: not a git repository

Which causes gitstatus.py to output garbage results. Easy fix is to compare using .lower()

@fam4r
Copy link

fam4r commented Apr 19, 2018

Please see here: #103

@juanibiapina
Copy link

A better option is to compare the status code:

if gitsym.returncode != 0:
        sys.exit(0)

cbeneke added a commit to cbeneke/zsh-git-prompt that referenced this issue May 28, 2018
@fam4r
Copy link

fam4r commented May 31, 2018

Yes, that has been discussed in #103 and there's a PR in #119 , just in case you want to join the thread 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants