Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

influx_log gives vague and unhelpful output #153

Open
hagertnl opened this issue Dec 7, 2023 · 1 comment
Open

influx_log gives vague and unhelpful output #153

hagertnl opened this issue Dec 7, 2023 · 1 comment
Labels
invalid This doesn't seem right

Comments

@hagertnl
Copy link
Contributor

hagertnl commented Dec 7, 2023

Running under --mode influx_log gives very vague output, like the following:

Using machine config: frontier.ini
Using machine config: frontier.ini
/lustre/orion/stf016/proj-shared/hagertnl/applications
Overriding tasks in inputfile since CLI mode was provided
runmodecmd =  ['influx_log']
self.__harness_task:  [['influx_log', None, None]]
reading harness config /sw/acceptance/olcf-test-harness/configs/frontier.ini
RGT_PATH_TO_SSPACE is already set. Skipping.
RGT_SYSTEM_LOG_TAG is already set. Skipping.
Starting tasks for Application.Test: coral2-lammps.test_0001node_17mil_reax: [['influx_log', None, None]]
Skipped 0, launched 1.

This is pretty unhelpful. More messages about what's going on by default would be appreciated.

@hagertnl hagertnl added the invalid This doesn't seem right label Dec 7, 2023
@hagertnl hagertnl added this to the v3 target fixes milestone Dec 21, 2023
@hagertnl
Copy link
Contributor Author

hagertnl commented Jan 4, 2024

Removing from v3 target fixes -- this bug requires refactorization and proper error message returns from methods. For example, in apptest.py, the return value of logging_status_file.post_event_to_influx is not stored, so we have no validation on if the event posted successfully or not.

I think the solution to this bug will be to report certain metrics such as number of successfully logged events/metrics, failed to log events/metrics, skipped for incorrect machine name, or skipped/already-logged. Need to correct this return value issue before we can add proper metrics.

@hagertnl hagertnl removed this from the v3 target fixes milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant