Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generates an incorrect URL for a Redux Toolkit nested entry point #58

Open
markerikson opened this issue Aug 18, 2023 · 3 comments
Open

Comments

@markerikson
Copy link

I'm trying to bundle this set of exports:

export { configureStore } from "@reduxjs/toolkit";
export {createApi} from "@reduxjs/toolkit/query/react";
export { Provider } from "react-redux";

It downloads React-Redux okay, but fails to download the RTK /query/react entry point, because it's generating a wrong version URL (1.0.0, when the current version is 1.9.5):

✘ [ERROR] Do not know how to load path: http-url:https://unpkg.com/@reduxjs/toolkit@1.0.0/dist/query/react/rtk-query-react.esm.js


/input.ts:2:24:

      2 │ export {createApi} from "@reduxjs/toolkit/query/react";
        ╵                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@okikio
Copy link
Owner

okikio commented Oct 31, 2023

This is an issue with the package.json of @reduxjs/toolkit

https://unpkg.com/@reduxjs/toolkit@1.9.7/query/react/package.json

{
    "name": "@reduxjs/toolkit-query-react",
    "version": "1.0.0",
    "description": "",
    "main": "../../dist/query/react/index.js",
    "module": "../../dist/query/react/rtk-query-react.esm.js",
    "unpkg": "../../dist/query/react/rtk-query-react.umd.min.js",
    "author": "Mark Erikson <mark@isquaredsoftware.com>",
    "license": "MIT",
    "types": "../../dist/query/react/index.d.ts",
    "sideEffects": false
}

The version mismatch confuses bundlejs, I'm thinking about what the best solution for this would be? 🤔

@markerikson
Copy link
Author

Hmm. Yeah, part of the problem here is that this is actually all one package, with multiple entry points. That package.json file only exists so that alternate entry points work with Node's existing resolution algorithm.

The version numbers in those are pretty irrelevant, but technically I could update those as part of the build process, I guess.

RTK 2.0 has proper ESM and package.exports support, so that should improve things.

But, both these attempts error in different ways:

export { configureStore } from "@reduxjs/toolkit@2.0.0-beta.4";
export {createApi} from "@reduxjs/toolkit@2.0.0-beta.4/query/react";
// or
// export {createApi} from "@reduxjs/toolkit/query/react@2.0.0-beta.4";
export { Provider } from "react-redux";

@okikio
Copy link
Owner

okikio commented Oct 31, 2023

I'll look into way to fix that behavior so it still bundles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants