Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the {% include relative-baseurl.html %} #148

Open
tordans opened this issue Mar 3, 2018 · 0 comments
Open

Get rid of the {% include relative-baseurl.html %} #148

tordans opened this issue Mar 3, 2018 · 0 comments

Comments

@tordans
Copy link
Contributor

tordans commented Mar 3, 2018

I don't see any reason what would be bad to follow the default Jekyll behaviour (with a current Jekyll version, see PR) and use absolute URLs everywhere.

The advantage is, we could get rid of all those {% include relative-baseurl.html %} includes that are cluttered all over the place.

If the absolute-url-idea is a problem, we could at least check if the include in _layouts/basic.html is not enough for all the other pages. IMO a variable only needs to be assigned once, not in every single file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant