Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-correcting sucks hard #534

Closed
c2h2 opened this issue Aug 8, 2011 · 64 comments · Fixed by #2316
Closed

auto-correcting sucks hard #534

c2h2 opened this issue Aug 8, 2011 · 64 comments · Fixed by #2316

Comments

@c2h2
Copy link

c2h2 commented Aug 8, 2011

the auto correcting always convert like ddd -> dd, very annoying, can we disable auto correcting by default?

@pstadler
Copy link
Contributor

pstadler commented Aug 8, 2011

unsetopt correct_all

should do it.

@robbyrussell
Copy link
Member

You can set some custom overrides for commands you use most often... but this feature will stay on by default (until I'm convinced it's annoying).

Check out this file for more details... you can set overrides in custom to your heart's content.

@Frost
Copy link

Frost commented Oct 3, 2011

I think setopt correct would be a much more sensible default setting. setopt correctall will for example try to automatically correct any word in a command to some file or whatever else it'll find in your autocomplete path (user home-dirs, servers from .ssh/config, etc).

At least it's not autocorrect, or I probably would've started a damnyouzshcorrectall.com site by now ;p

@isimmons
Copy link

isimmons commented Nov 1, 2012

It is annoying. On Ubuntu I installed 'tree' and then try to run it and it asks every time if I want it to correct to 'tee'. Now why would I want it to do that? :-) Thanks for an awesome shell but spell correct is for word processors, not terminals IMHO.

Thank you for the overrides info.

Thank you pstadler for the line to disable it. Dropped that in my .zshrc file and it turned that annoying thing off.

@sheerun
Copy link
Contributor

sheerun commented Nov 14, 2012

It's damn annoying.

@techmaniack
Copy link

It is annoying 💩

@hrj
Copy link

hrj commented Mar 5, 2013

🐸 Very annoying. Please disable auto correct all by default. I have tens of user profiles and I always get burned by this and it is annoying to have to disable it or to remember to disable it after creating a fresh user profile.

@trobrock
Copy link
Contributor

trobrock commented Mar 7, 2013

I really only find this annoying when using bundler binstubs, has anyone found any of of getting the correction system to support binstubs?

@BBonifield
Copy link
Contributor

Agreed that this is annoying. I think the more sensible default would be to have it off.

@tyro89
Copy link

tyro89 commented Mar 22, 2013

Agreed that this is annoying, keeps asking me if I want to correct git status to git stats...

@virtuallybing
Copy link

+1

5 similar comments
@mikeabiezzi
Copy link

+1

@smalltotem
Copy link

+1

@jessicard
Copy link

+1

@messick
Copy link

messick commented Mar 22, 2013

👍

@ryanneufeld
Copy link
Contributor

+1

@wookiehangover
Copy link

👍

@mcfilib
Copy link

mcfilib commented Mar 28, 2013

+1

@twaldecker
Copy link

👍

@antitoxic
Copy link

Definitely annoying.

@jeffdc
Copy link

jeffdc commented Apr 2, 2013

count me into the annoying camp

@tyro89
Copy link

tyro89 commented Apr 2, 2013

@robbyrussell I think this might be worth taking a look at again.

@paulkoegel
Copy link

After a recent oh-my-zsh update i keep getting auto correct suggestions despite having unsetopt correct_all in my .zshrc =(

@mcfilib
Copy link

mcfilib commented Apr 5, 2013

@paulwittmann Likewise. I added the following to mine.

unsetopt correct_all
unsetopt correct

@paulkoegel
Copy link

@unsymbol thanks so much, works like a charm!

@bigeasy
Copy link

bigeasy commented Apr 7, 2013

Help! Help! Jane, stop this crazy thing! Jane!

@teddyknox
Copy link

+1

@rummik
Copy link
Contributor

rummik commented Jun 4, 2013

@isimmons What's more annoying is that Zsh doesn't pick up on newly installed programs. Try tab-completing something you've just installed

@hrj
Copy link

hrj commented Jun 5, 2013

@rummik That's a different issue. You can run rehash to let zsh find newly installed programs or PATH changes.

@matthewrobertson
Copy link

👍

@mcfilib
Copy link

mcfilib commented Aug 13, 2013

👍

@messick
Copy link

messick commented Oct 16, 2013

👍

@BBonifield
Copy link
Contributor

@robbyrussell It seems that there is still a number of people that would prefer a change. Are you convinced that it's annoying yet?

@Domon
Copy link

Domon commented Oct 17, 2013

👍

@0X1A
Copy link

0X1A commented Oct 17, 2013

@BBonifield Doubtful, this thread is 2 years old and it's still in.

@messick
Copy link

messick commented Oct 17, 2013

@0X1A We need to stay strong. Change only comes to those who continue to fight for what is right.

@Profpatsch
Copy link
Contributor

👍

@tsalzer
Copy link

tsalzer commented Oct 18, 2013

Please disable or remove autocorrect by default.

@NobbZ
Copy link

NobbZ commented Oct 18, 2013

👍
Am 18.10.2013 17:14 schrieb "Till Salzer" notifications@github.com:

Please disable or remove autocorrect by default.


Reply to this email directly or view it on GitHubhttps://github.com//issues/534#issuecomment-26603782
.

@rummik
Copy link
Contributor

rummik commented Oct 18, 2013

Because it's so hard to type print "unsetopt correct\nunsetopt correct_all" >> ~/.zshrc

@sheerun
Copy link
Contributor

sheerun commented Oct 18, 2013

@rummik It's the only thing that annoys me in out of the box oh-my-zsh configuration. And of course it's hard to type, you need to google for it.

@rummik
Copy link
Contributor

rummik commented Oct 18, 2013

@sheerun man zshoptions

@hrj
Copy link

hrj commented Oct 19, 2013

It's not just about the inconvenience of changing the defaults. The bigger problem is, the defaults are dangerous! OMZSH changes my command in a very unintuitive and unexpected way. I have, on occasions, deleted files due to this feature when I was new to OMZSH. Luckily, those files were version controlled, and I learnt the options to disable auto correct.

These days, I don't bother installing OMZSH into new user profiles. Of course, since it is open-source, I could fork it. But I am now wary of using such a tool, given that the creators are blind to potentially destructive features.

(sigh) I did like the project once upon a time.

@0X1A
Copy link

0X1A commented Oct 21, 2013

@hrj I agree with you man, there's been too many times where the autocorrect is something completely unrelated and I press enter out of muscle memory. It's pretty annoying but I don't think it'll end up getting changed anytime soon.

@jakobhans
Copy link

+1

@robbyrussell
Copy link
Member

Admittedly, I don't think I've seen this thread since I closed it. I typically only look at pull-requests.

Who wants to send one..?

@BBonifield
Copy link
Contributor

@robbyrussell Pull request added, comments appreciated!

@hakusaro
Copy link

hakusaro commented Dec 5, 2013

Thank. God.

@BBonifield
Copy link
Contributor

@robbyrussell Thanks for the quick merge!

@messick
Copy link

messick commented Dec 5, 2013

I feel as a shadow has been lifted from my soul. Our long dark nightmare is finally over! Congratulations everybody!

@jakobhans
Copy link

Thank you @robbyrussell and @BBonifield

@mablae
Copy link

mablae commented Dec 5, 2013

Awsome! Finally!

@0X1A
Copy link

0X1A commented Dec 6, 2013

:shipit:

@Drarok
Copy link
Contributor

Drarok commented Jul 17, 2014

So this is why auto-correct stopped working!

@unphased
Copy link

@Drarok Ha, yeah looks like it.

You know I would leave it on if it was actually smart.

For example:

gitf etch --> git etch

Dammit, be smarter!!

I'm kind of not serious. enabling correction to mess with the arguments is probably not a safe thing to do.

I guess i'm switching it back off now.

@geoyws
Copy link

geoyws commented Dec 8, 2019

@hrj Hm. Hadn't known about rehash. Seems like a wrapper for various package managers that does a rehash afterward would be handy.

My point was more that @isimmons' problem with completion was because Zsh didn't know about the program he had just installed, so it was correcting him

Wished rehash could be automatically run at some convenient hook someplace.

@sca255
Copy link

sca255 commented Jun 12, 2022

i like auto correct .
it helped me 1000s of time

@ohmyzsh ohmyzsh locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.