Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for omz update #12168

Open
mcandre opened this issue Jan 17, 2024 · 1 comment
Open

Improvements for omz update #12168

mcandre opened this issue Jan 17, 2024 · 1 comment
Assignees
Labels
Feature New feature or request

Comments

@mcandre
Copy link

mcandre commented Jan 17, 2024

If the feature request is for a plugin or theme, specify it here.

No response

If the feature solves a problem you have, specify it here.

The update subcommand has some UX quirks, around basic things like the discoverability of flags, and validation, that could be likely addressed with some quick patches.

Describe the proposed feature.

Hi,

I have a few simple suggestions for the update process.

First, please consider performing exec zsh at the end of the script after an update. Currently, omz update launches a nested shell after an update. This results in some awkward interactions with SSH terminals and larger automation scripts, because of the need to sometimes, but not always, backout of the extra shell session, when in fact there are updates.

Second, the --unattended flag is difficult to discover. I'd love to see the CLI help menu extended to document this option for the update subcommand, so that it is easier to find. Some random online discussions imply such a flag, but they mostly talk about it for installation, not updating. I was only able to test the behavior of the flag by performing a manual git reset HEAD~1 --hard in the ~/.oh-my-zsh directory.

Third, the CLI validation could be improved. omz update nosuchflag appears to silently reject bad arguments. If the user supplies invalid arguments, I'd like to see a non-zero exit code and the relevant help menu.

Describe alternatives you've considered

No response

Additional context

No response

Related Issues

No response

@mcandre mcandre added the Feature New feature or request label Jan 17, 2024
@carlosala
Copy link
Member

Hi Andrew, thanks for the ideas!

  1. Sounds sensible to me, but it is actually what happens at the end of successful update
  2. It would be great to update the help and completion to make --unattended easier to discover and document it in the README.
  3. Sounds sensible as well 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

3 participants