Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't scroll down in some doc pages #2

Open
bovas85 opened this issue May 24, 2019 · 14 comments
Open

Can't scroll down in some doc pages #2

bovas85 opened this issue May 24, 2019 · 14 comments

Comments

@bovas85
Copy link

bovas85 commented May 24, 2019

On mobile and desktop mode on chrome latest on android 9 I can't scroll down the page where other examples are.
Link https://react-hooks-cheatsheet.surge.sh/useeffect

Seems an issue with fixed heights or overflow being hidden.

I can send a PR later today unless you can fix earlier

@ohansemmanuel
Copy link
Owner

@bovas85 thanks for opening the issue. I can have a look later today, however, it'd be great if you sent a PR as well 😊

@bovas85
Copy link
Author

bovas85 commented May 28, 2019

I'll try to once I get a moment. Crazy weekend (it was holiday on Monday here in UK)

@ohansemmanuel
Copy link
Owner

Totally get it! 😆

@aspiers
Copy link

aspiers commented Jul 10, 2019

I see the same issue.

@ohansemmanuel
Copy link
Owner

I'll look into this.

@intisavariable
Copy link

I have the same issue. If I open the page on portrait mode (snap the browser window to half a screen) it does not scroll at all. If a page is opened in landscape (fullscreen) and then resized to portrait it works fine.

@intisavariable
Copy link

I cloned the repo, will look into trying to fix it if I can figure out what's the problem, any help/suggestions welcome

@intisavariable
Copy link

Update:
The bug only occurs after opening the hamburger menu and clicking the link.
It does not persist through the refresh.

@ohansemmanuel
Copy link
Owner

Thanks @intisavariable I've had my hands full. Any luck with this? I'll perhaps take a second look today too.

@bovas85
Copy link
Author

bovas85 commented Jun 4, 2020

the issue is clear but I have no idea how to fix it due to the abstractions on top of the docs.

the HTML tag gets a class of with-overlay which is not removed upon route change

@ohansemmanuel
Copy link
Owner

@bovas85 do you get the same issue with this link: https://react-hooks-cheatsheet.com/useeffect
i.e can't scroll down

@bovas85
Copy link
Author

bovas85 commented Jun 4, 2020

Yes, I can't open nested menu items as well, but the issue appears once you go to a menu and to another page. The overflow: hidden of the html tag is not removed

@ohansemmanuel
Copy link
Owner

I'm gonna perhaps rewrite to use another documentation library. Shouldn't be as much work since the core by itself is just MDX and basic React components

@knownasilya
Copy link

Adding an overflow-y: auto to #root fixes the issue, seems like a rewriting would be more work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants