Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove constant_hessian_value? #89

Open
NicolasHug opened this issue Jan 2, 2019 · 1 comment
Open

Remove constant_hessian_value? #89

NicolasHug opened this issue Jan 2, 2019 · 1 comment

Comments

@NicolasHug
Copy link
Collaborator

NicolasHug commented Jan 2, 2019 •
edited

I think we can drop the constant_hessian_value in the SplittingContext, and always assume the constant hessians value is 1. We just have to set the gradients value accordingly, to have consistent leaf values.

This is what we do for LS loss already. WDYT @ogrisel ?
@ogrisel
Copy link
Owner

ogrisel commented Jan 28, 2019

As you wish. +0 to simplify the code a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ogrisel @NicolasHug