New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse grower (and thus the splitter) instead of creating a new one #81

Open

NicolasHug opened this issue Dec 18, 2018 · 0 comments

Labels

perf

Collaborator

NicolasHug commented Dec 18, 2018

A new grower (and a new SplittingContext) is created at each iteration which may cause a memory use peak on large datasets (#79).

Instead of instanciating a new grower, we could just reset it and reuse the allocated space.

See #79 (comment) to evaluate the changes

NicolasHug added the perf label

NicolasHug mentioned this issue

Optionally use left/right indices buffer #83

Open

NicolasHug mentioned this issue

[MRG] Reuse grower and splitter memory #88

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment