Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive display issue for "Join a Future Camp" button #122

Open
terichadbourne opened this issue Feb 16, 2017 · 6 comments
Open

Responsive display issue for "Join a Future Camp" button #122

terichadbourne opened this issue Feb 16, 2017 · 6 comments
Assignees

Comments

@terichadbourne
Copy link
Contributor

The "Join Waitlist" button on the top right of the camp website looks bad on small screen sizes.

Need to fixes both the layout > camp-detail and layout > camp-index pages and apply responsive design skills to fix.

@gr2m
Copy link
Collaborator

gr2m commented Feb 16, 2017

@terichadbourne you mean this? It's not ideal but no too bad either I think

screen shot 2017-02-16 at 14 22 46

Or does it look like different for you?

@terichadbourne
Copy link
Contributor Author

Yes, that's what I see is well. I have high standards. :)

@kidfribble
Copy link
Collaborator

I think the technical term for this mobile nav is "jank" 🔧

@Ryuno-Ki
Copy link

What about adjusting the baseline? Centering it would mean the button/box goes up.

@terichadbourne terichadbourne changed the title Join Waitlist button is broken on small screen sizes Responsive display issue for "Join a Future Camp" button Apr 5, 2017
@terichadbourne
Copy link
Contributor Author

New button is there now and @kidfribble has mostly fixed the formatting issues, but the pink button is wrapping down onto a pink background on some browsers. (Screenshot is from Chrome on a Macbook.)

image

@terichadbourne
Copy link
Contributor Author

This is the current state on mobile:

image

@kidfribble shall I close this out? I'd volunteer to make a hamburger nav but am really strapped for time and I expect we're about to have lots of changes regardless when you and Ian update the camp site structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants