Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP-IDF Support #47

Open
kzoltaan opened this issue Dec 5, 2019 · 9 comments
Open

ESP-IDF Support #47

kzoltaan opened this issue Dec 5, 2019 · 9 comments

Comments

@kzoltaan
Copy link

kzoltaan commented Dec 5, 2019

Do you plan to make it for ESP-IDF?

@ofekp
Copy link
Owner

ofekp commented Dec 5, 2019

Are you referring to this repo?
Can you be more specific?
I mean if you have the Arduino IDE, it is just a simple include to use this package, what is the extra benefit of having this directly supported in ESP-IDF?

@kzoltaan
Copy link
Author

kzoltaan commented Dec 5, 2019

I'm using https://github.com/espressif/esp-at with custum command set and custom knowledge. I compile it under Linux. I would like to use it like esp_http_server or other as a component. No Arduino ide. I don't like it

@peergum
Copy link

peergum commented Nov 4, 2022

I need UPnP for ESP-IDF, so I'll start working on a port for that framework instead of Arduino (not for ESP-AT though)

@ofekp
Copy link
Owner

ofekp commented Nov 4, 2022

Please create a pull request for the benefit of others and I will help merging, thank you

@kzoltaan
Copy link
Author

kzoltaan commented Nov 4, 2022

I need UPnP for ESP-IDF, so I'll start working on a port for that framework instead of Arduino (not for ESP-AT though)

Sounds good. I droped ESP-AT, I'm using IDF. I'm really looking forward to this!

@peergum
Copy link

peergum commented Nov 6, 2022

Please create a pull request for the benefit of others and I will help merging, thank you

I will. Note that I'm trying to make as few changes possible to your code, but it's pretty hard due to the differences in libs and classes between ESP-IDF and Arduino. ESP-IDF requires a completely different config for compilation, based on cmake. I feel it's pretty much a distinct fork from your project, but I can use your code as a base, and will reference it as such.

@peergum
Copy link

peergum commented Nov 15, 2022

I decided to create a complete c++ component to facilitate the use of Wifi, TCP and UDP client/servers, and I will include UPnP in it. I realized there's too much to port to ESP-IDF and each thing I'm porting requires its own class, so a global component will be much more useful and easier to maintain.

@ofekp
Copy link
Owner

ofekp commented Dec 4, 2022

@peergum can you place a link to where you're doing this, please?

@peergum
Copy link

peergum commented Dec 4, 2022

@ofekp I committed the initial version of a component two days ago here and referenced your work here as the base for the UPnP part. I had to do many changes, due to the absence of several classes in the IDF framework (like String). I also had to write TCPClient and UDPClient classes for it to work. Mostly the main UPnP logic is yours, and it works, but it's quite far from your Arduino version. There are many parts I would have done slightly differently from you, but my goal here was mostly to get something running on IDF quickly. I hope it helps people who do not use the Arduino framework. Note that it is based on latest version of the ESP-IDF framework, v5.0 (just officially released 2 days ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants