Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify of outstanding forward ports on the forward port instead of the source #836

Open
xmo-odoo opened this issue Jan 24, 2024 · 0 comments
Labels
forwardbot nice to have maybe eventually implement that, not critical
Projects

Comments

@xmo-odoo
Copy link
Collaborator

Req'd by xdo.

When the reminder was overhauled with #198 decision was made to only warn on the original PR because

there's no need to explicitly at-tag the author or reviewer, they're likely following the original PR still

however,

  • later on at-tagging the author and reviewer were added anyway
  • this affects other followers of the original PR, not just the author and reviewer

Furthermore this increases the number of steps necessary to fix the issue, as the user trying to handle it has to go to the PR, check the reminder comment, open the linked PRs, then handle them.

It might be a better idea to ping the outstanding forward ports, this removes a step from their handling, and avoid pinging all the followers of the original task, most of whom probably don't care anyway.

@xmo-odoo xmo-odoo added forwardbot nice to have maybe eventually implement that, not critical labels Jan 24, 2024
@xmo-odoo xmo-odoo added this to ideas in Mergebot via automation Jan 24, 2024
@xmo-odoo xmo-odoo moved this from ideas to accepted in Mergebot Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardbot nice to have maybe eventually implement that, not critical
Projects
Mergebot
accepted
Development

No branches or pull requests

1 participant