Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate moving forward-porting to ORT merges and zdiff3 conflicts #827

Open
xmo-odoo opened this issue Nov 29, 2023 · 0 comments
Open
Labels
Projects

Comments

@xmo-odoo
Copy link
Collaborator

xmo-odoo commented Nov 29, 2023

Currently the mergebot does not configure the merge strategy for cherrypicking, and uses merge.conflictstyle=diff3 for markers.

  • cherrypicking might be more reliable with the "ort" strategy, although maybe not as that supposedly is the default when "pulling or merging one branch" so maybe it's already in use

  • zdiff3 can be slightly cleaner than diff3 visually (and less confusing) because it

    removes matching lines on the two sides from the conflict region when those matching lines appear near either the beginning or end of a conflict region.

    These are lines which don't appear in the conflict zone of a merge (diff2), because diff2 already moves them out of the conflict markers even though they're technically part of the conflict area.

@xmo-odoo xmo-odoo added this to ideas in Mergebot via automation Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

1 participant