Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][BUG] rating: Missing multi-company rule #163001

Open
carolinafernandez-tecnativa opened this issue Apr 23, 2024 · 3 comments
Open

[16.0][BUG] rating: Missing multi-company rule #163001

carolinafernandez-tecnativa opened this issue Apr 23, 2024 · 3 comments

Comments

@carolinafernandez-tecnativa
Copy link

Impacted versions:
15.0, 16.0, 17.0

Steps to reproduce:

1- Multi-environment configuration
2- Allow customer ratings on project.
3- Go to Project > Reporting > Customer ratings
4- All customer ratings belong to Company San Francisco.

image

5- User is current on Company Chicago

image

6- Tried to access one customer rating

image

Current behavior:

If I have multi-company environment, all customer ratings tasks are not being filtered by company, it shows all ratings for all companies, independently which company is the user at.

Expected behavior:

If I have multi-company environment, when i go to check customer ratings task as an example, it has to show only task rating for the company that user is logged in.
In this example, when the user is with Company Chicago, when access to Customer ratings, it should be an empty list.

Please note, there is no field company_id on model rating.rating and security rule is missing.

cc @Tecnativa TT48683

@carolinafernandez-tecnativa carolinafernandez-tecnativa changed the title [16.0][BUG] Missing multi-company rules on rating [16.0][BUG] Missing multi-company rule on rating Apr 23, 2024
@carolinafernandez-tecnativa carolinafernandez-tecnativa changed the title [16.0][BUG] Missing multi-company rule on rating [16.0][BUG] rating: Missing multi-company rule Apr 23, 2024
@pedrobaeza
Copy link
Collaborator

@mart-e do you know who is in charge of this module?

@vava-odoo
Copy link
Contributor

That would be something for @xavierbol. Could you have a look?

@pedrobaeza
Copy link
Collaborator

I think this can be implemented overriding _check_access and checking if the user have access to the rating related record. This way, it's not only multi-company, but any other restriction through record rules can be checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants