Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while building on Windows (no_sanitize_address, unrecognized extended attribute) #3449

Open
kr4ft3r opened this issue Apr 18, 2024 · 1 comment

Comments

@kr4ft3r
Copy link

kr4ft3r commented Apr 18, 2024

Context

Attempting to build on Windows with x64 Native Tools Command Prompt for VS 2017 fails. The instructions seem missleading as only the standard powershell succeeded, while VS 2017 command prompt fails complaining about unrecognized extended attribute no_sanitize_address.

  • Operating System & Odin Version: Windows 10 22H2 , dev-2024-04a
  • Please paste odin report output:

Expected Behavior

Running x64 Native Tools Command Prompt for VS 2017 and build.bat from cloned repo should build without errors.

Current Behavior

Build fails:

D:\Work\Odin>build.bat
main.cpp
libtommath.cpp
d:\work\odin\src\gb\gb.h(3581): error C2485: 'no_sanitize_address': unrecognized extended attribute (compiling source file src\main.cpp)
@laytan
Copy link
Sponsor Contributor

laytan commented May 2, 2024

#if defined(_MSC_VER)

Should be #if defined(_MSC_VER) && !defined(__clang__) I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants