Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want the variable key automated in herman-add mixins #158

Open
mirisuzanne opened this issue Sep 6, 2017 · 1 comment
Open

I want the variable key automated in herman-add mixins #158

mirisuzanne opened this issue Sep 6, 2017 · 1 comment

Comments

@mirisuzanne
Copy link
Member

When we add a variable to the output map, we have to set a key that Herman will look for, as well as providing the variable:

@include herman-add('my-colors', $my-colors);

It would be great to automate the key, and only pass in the value – but not simple in Sass. We can't easily get one (key or value) based on the other.

@mirisuzanne mirisuzanne added this to the Herman 1.0 milestone Sep 6, 2017
@mirisuzanne
Copy link
Member Author

I have a long-shot idea for this, using the Sass compilation-order to automate keys - rather than the object name. It feels a bit fragile to me at first, but theoretically, Sass and Herman should always compile the documents in the same order – so they should both be able to determine the proper key reliably.

@jgerigmeyer jgerigmeyer modified the milestones: Herman 1.0, Herman 1.x Stretch Goals Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants