Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis step in a transient state #685

Open
maiste opened this issue Dec 13, 2022 · 3 comments
Open

Analysis step in a transient state #685

maiste opened this issue Dec 13, 2022 · 3 comments
Labels
type/bug Something isn't working type/enhancement New feature or request

Comments

@maiste
Copy link
Member

maiste commented Dec 13, 2022

Sometimes, when running the analysis step, it wouldn't rebuild, get stuck and would always show the same error message. To solve that locally, the solution is to clean the local state and rerun the CI.

It needs more investigation but it could be solved by the solver-service.

@maiste maiste added type/bug Something isn't working type/enhancement New feature or request labels Dec 13, 2022
@tmcgilchrist
Copy link
Member

An example from ocaml/ocaml-file-format https://ci.ocamllabs.io:8100/job/2022-12-13/165403-git-fetch-7502d0

2022-12-13 16:54.03: New job: git fetch https://github.com/ocaml/opam-file-format.git#refs/pull/47/head (91af0c0e6148bda1e268c35dc8f62159d254649e)
2022-12-13 16:54.03: Exec: "git" "-C" "/var/lib/ocurrent/var/git/opam-file-format.git-86eb760e672d02d33591ec88eb8e890f599af36acbd25c5eac00005e3f372f69" 
                           "branch" "-f" "fetch-91af0c0e6148bda1e268c35dc8f62159d254649e" 
                           "91af0c0e6148bda1e268c35dc8f62159d254649e"
fatal: Not a valid branch point: '91af0c0e6148bda1e268c35dc8f62159d254649e'.
2022-12-13 16:54.03: Exec: "git" "-C" "/var/lib/ocurrent/var/git/opam-file-format.git-86eb760e672d02d33591ec88eb8e890f599af36acbd25c5eac00005e3f372f69" 
                           "fetch" "--recurse-submodules=false" "-q" 
                           "-f" "https://github.com/ocaml/opam-file-format.git" 
                           "refs/pull/47/head"
2022-12-13 16:54.03: Exec: "git" "-C" "/var/lib/ocurrent/var/git/opam-file-format.git-86eb760e672d02d33591ec88eb8e890f599af36acbd25c5eac00005e3f372f69" 
                           "branch" "-f" "fetch-91af0c0e6148bda1e268c35dc8f62159d254649e" 
                           "91af0c0e6148bda1e268c35dc8f62159d254649e"
fatal: Not a valid branch point: '91af0c0e6148bda1e268c35dc8f62159d254649e'.
2022-12-13 16:54.03: Job failed: Command "git" "-C" "/var/lib/ocurrent/var/git/opam-file-format.git-86eb760e672d02d33591ec88eb8e890f599af36acbd25c5eac00005e3f372f69" 
"branch" "-f" "fetch-91af0c0e6148bda1e268c35dc8f62159d254649e" "91af0c0e6148bda1e268c35dc8f62159d254649e" exited with status 128

The git commit in question does not belong to any branch on this repository, and may belong to a fork outside of the repository. Looking at the PR for that job ocaml/opam-file-format#47 that commit is available.

Rerunning the fetch step just now gives:

2022-12-13 22:08.46: New job: git fetch https://github.com/ocaml/opam-file-format.git#refs/pull/47/head (91af0c0e6148bda1e268c35dc8f62159d254649e)
2022-12-13 22:08.46: Exec: "git" "-C" "/var/lib/ocurrent/var/git/opam-file-format.git-86eb760e672d02d33591ec88eb8e890f599af36acbd25c5eac00005e3f372f69" 
                           "branch" "-f" "fetch-91af0c0e6148bda1e268c35dc8f62159d254649e" 
                           "91af0c0e6148bda1e268c35dc8f62159d254649e"
fatal: Not a valid branch point: '91af0c0e6148bda1e268c35dc8f62159d254649e'.
2022-12-13 22:08.46: Exec: "git" "-C" "/var/lib/ocurrent/var/git/opam-file-format.git-86eb760e672d02d33591ec88eb8e890f599af36acbd25c5eac00005e3f372f69" 
                           "fetch" "--recurse-submodules=false" "-q" 
                           "-f" "https://github.com/ocaml/opam-file-format.git" 
                           "refs/pull/47/head"
2022-12-13 22:08.47: Exec: "git" "-C" "/var/lib/ocurrent/var/git/opam-file-format.git-86eb760e672d02d33591ec88eb8e890f599af36acbd25c5eac00005e3f372f69" 
                           "branch" "-f" "fetch-91af0c0e6148bda1e268c35dc8f62159d254649e" 
                           "91af0c0e6148bda1e268c35dc8f62159d254649e"
2022-12-13 22:08.47: Exec: "git" "-C" "/var/lib/ocurrent/var/git/opam-file-format.git-86eb760e672d02d33591ec88eb8e890f599af36acbd25c5eac00005e3f372f69" 
                           "reset" "--hard" "-q" "91af0c0e6148bda1e268c35dc8f62159d254649e"
2022-12-13 22:08.47: Exec: "git" "-C" "/var/lib/ocurrent/var/git/opam-file-format.git-86eb760e672d02d33591ec88eb8e890f599af36acbd25c5eac00005e3f372f69" 
                           "submodule" "sync"
2022-12-13 22:08.47: Exec: "git" "-C" "/var/lib/ocurrent/var/git/opam-file-format.git-86eb760e672d02d33591ec88eb8e890f599af36acbd25c5eac00005e3f372f69" 
                           "submodule" "deinit" "--force" "--all"
2022-12-13 22:08.47: Exec: "git" "-C" "/var/lib/ocurrent/var/git/opam-file-format.git-86eb760e672d02d33591ec88eb8e890f599af36acbd25c5eac00005e3f372f69" 
                           "submodule" "update" "--recursive" "--init"
2022-12-13 22:08.47: Job succeeded

@novemberkilo
Copy link
Contributor

Sometimes this requires that the worker's cache be wiped. Rebuilding a step from the UI results in the same worker being picked (unless it has been paused or taken down). Is it possible to improve the results of a rebuild by choosing a different worker for the rebuild?

@mtelvers
Copy link
Member

mtelvers commented Mar 7, 2023

This might occasionally make the rebuild work where it previously failed, but on the whole, this would be a significant performance hit. Better to try to detect the issue on the worker and get it to fix/delete the cache. Such as what @kit-ty-kate did here ocurrent/ocluster@318a69f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants