Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure properties/keys cannot contain '.' character #33

Open
thclark opened this issue Aug 1, 2020 · 1 comment
Open

Ensure properties/keys cannot contain '.' character #33

thclark opened this issue Aug 1, 2020 · 1 comment
Assignees

Comments

@thclark
Copy link
Collaborator

thclark commented Aug 1, 2020

Since the data structure in values can be deeply nested, it is extremely helpful to be able to define a path to that node in the json schema.

Thus, restricting to keys which do not contain the '.' character allows us to define a path as "input_values_schema.prop_a.prop_b" and refer to that node of the schema independently.

This is extremely useful in e.g. creating drag and drop type schema editors.

@thclark thclark self-assigned this Aug 1, 2020
@thclark thclark added the schema label Aug 1, 2020
@thclark
Copy link
Collaborator Author

thclark commented Aug 1, 2020

Worth also noting that many frontend solutions for managing twines and json schema will assume this constraint already, and would break without it.

@thclark thclark added this to Twined v0.0.x in Twined Ecosystem Roadmap Nov 26, 2020
@thclark thclark removed the schema label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Priority 2 (Medium)
Development

No branches or pull requests

1 participant