Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty configuration_schema raises InvalidTwine #25

Open
thclark opened this issue Feb 4, 2020 · 0 comments
Open

Empty configuration_schema raises InvalidTwine #25

thclark opened this issue Feb 4, 2020 · 0 comments
Assignees
Labels
bug Unintended behaviour in any area of the app

Comments

@thclark
Copy link
Collaborator

thclark commented Feb 4, 2020

Parsing the following Configuration Schema raises an InvalidTwine:

"configuration_schema": {},

It seems to me that for general usability, this should be allowable and simply treated as not present.

Note that an empty python dict tests as boolean false:

dict1 = {}
if dict1:
    print("dict1 Not Empty")
else:
    print("dict1 is Empty")
>>> dict1 is Empty

So we either have to explicitly handle the case using that truth test, or have to update the schema to allow for an empty dict.

@thclark thclark self-assigned this Feb 4, 2020
@thclark thclark added the bug Unintended behaviour in any area of the app label Feb 4, 2020
@thclark thclark added this to Twined v0.0.x in Twined Ecosystem Roadmap Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unintended behaviour in any area of the app
Projects
Status: Priority 1 (Low)
Development

No branches or pull requests

1 participant