Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key similarity checker #16

Open
thclark opened this issue Jan 7, 2020 · 1 comment
Open

Key similarity checker #16

thclark opened this issue Jan 7, 2020 · 1 comment
Assignees
Labels
feature A new feature of the app

Comments

@thclark
Copy link
Collaborator

thclark commented Jan 7, 2020

In cases where a strand key (or a property key in a schema) is missing or absent, use levenshtein distance or fuzzy matching to determine whether a similar key is given in the input, then add a suggestion to the warning or error, e.g.:

Strand "credentials" is not present, but twine file contains key "crdntials" . Did you mean "credentials"?
@thclark thclark self-assigned this Jan 7, 2020
@thclark thclark added feature A new feature of the app schema labels Jan 7, 2020
@thclark thclark moved this from Triage to Will Fix in Twined Ecosystem Roadmap Dec 18, 2020
@thclark
Copy link
Collaborator Author

thclark commented Dec 18, 2020

Can also be used as a twine validation check. We can't exclude additional fields using the twine schema (in case people need to add their own metadata in the twine, or we want to add more strands), but we could apply this additional check after the twine has been read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature of the app
Projects
Status: Priority 1 (Low)
Development

No branches or pull requests

1 participant