Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to IEC definitions for terms in the design_basis descriptions #23

Open
thclark opened this issue Aug 1, 2023 · 1 comment
Open
Assignees
Labels
help wanted Applied by the assigned developer if they need help

Comments

@thclark
Copy link
Contributor

thclark commented Aug 1, 2023

In our meeting of 01 August 2023, we looked at the design_basis section in which we have a range of fields, such as inflow_angle ("gamma" in degrees).

For such values, there's an IEC standard defining the coordinate system, frame of reference and other aspects of these parameters. The descriptions of the fields should include a reference to this document.

Help required

  • get references to the (or all of the) IEC document(s) covering the parameters in the design basis section, and list them here so we can add those references into the schema (we probably only need the full document number)
@thclark thclark changed the title Add IEC definition for inflow angle frame of reference Add IEC definition for inflow angle frame of reference in the design basis Aug 1, 2023
@thclark thclark added the help wanted Applied by the assigned developer if they need help label Aug 1, 2023
@thclark thclark changed the title Add IEC definition for inflow angle frame of reference in the design basis Refer to IEC definitions for terms in the design_basis Aug 1, 2023
@thclark thclark changed the title Refer to IEC definitions for terms in the design_basis Refer to IEC definitions for terms in the design_basis descriptions Aug 1, 2023
@Dash16PM
Copy link
Collaborator

@thclark I agree we should refer to IEC standard definitions - the editing tool can help with this. (As an aside I made an error if I called inflow angle gamma. Inflow angle / slope of the terrain is normally referred to as "theta" although theta is also used for direction and temperature -- so subscripts matter. This is an editorial detail - we will get right once we send this out for review/before during internal clean up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Applied by the assigned developer if they need help
Projects
Status: Post first draft
Development

No branches or pull requests

2 participants