Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define IMGUI_VIDEO_CAPTURE_ENCODER_PATH #6

Open
jacobfriedman opened this issue Jan 16, 2023 · 2 comments
Open

Define IMGUI_VIDEO_CAPTURE_ENCODER_PATH #6

jacobfriedman opened this issue Jan 16, 2023 · 2 comments
Labels

Comments

@jacobfriedman
Copy link
Contributor

jacobfriedman commented Jan 16, 2023

It would be nice to have an IMGUI_VIDEO_CAPTURE_ENCODER_PATH definition included in imgui_capture_tool.h much like IMGUI_CAPTURE_DEFAULT_VIDEO_PARAMS[...]. In my world it would be conveniently sourced during ImGuiTestEngine_Postswap;

struct IMGUI_API ImGuiCaptureContext would contain char* VideoCaptureEncoderPath = IMGUI_VIDEO_CAPTURE_ENCODER_PATH or along those lines so we don't have to input it via the UI.

Thoughts?

@jacobfriedman
Copy link
Contributor Author

As a sidenote, IMGUI_CAPTURE_DEFAULT_VIDEO_PARAMS_FOR_FFMPEG should probably have the suffix dropped.

@ocornut
Copy link
Owner

ocornut commented Feb 23, 2023

Hello,

struct IMGUI_API ImGuiCaptureContext would contain char* VideoCaptureEncoderPath = IMGUI_VIDEO_CAPTURE_ENCODER_PATH or along those lines so we don't have to input it via the UI.

If you want to change the default value or force the value, you can write to test_io.VideoCaptureEncoderPath[] ?
If you ship or use a software that has an ffmpeg executable you can should setup that path yourself in the code.
We don't ship ffmpeg.exe in neither Test Suite or Test Engine so it wouldn't make sense to set a default.

As a sidenote, IMGUI_CAPTURE_DEFAULT_VIDEO_PARAMS_FOR_FFMPEG should probably have the suffix dropped.

I don't understand either. They are specifically default params in the case of using FFMPEG as an encoder.
We don't assume the encoder is FFMPEG but provide default params for that case.

@ocornut ocornut added the capture label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants