Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lake][Bug] The bronze PDR slots table has more than it needs to include #975

Closed
2 tasks
kdetry opened this issue Apr 30, 2024 · 2 comments
Closed
2 tasks

[Lake][Bug] The bronze PDR slots table has more than it needs to include #975

kdetry opened this issue Apr 30, 2024 · 2 comments
Assignees
@kdetry
Labels
Type: Bug Something isn't working

Comments

@kdetry
Copy link
Contributor

kdetry commented Apr 30, 2024

The bronze PDR slots table has more than it needs to include. Reported by @KatunaNorbert on slack

The timestamp value is also weird, some of them are just "1"

DoD

  • Inspect and fix the SQL
  • Test manually sure about the data result
@kdetry kdetry self-assigned this Apr 30, 2024
@kdetry kdetry added the Type: Bug Something isn't working label Apr 30, 2024
@kdetry kdetry mentioned this issue Apr 30, 2024
Merged
kdetry added a commit that referenced this issue May 7, 2024
@kdetry @KatunaNorbert
Fix #975 - Bronze PDR Slots Query Bug (#976)
355283b 
* issue-975 - bronze pdr slots query

* updated sql query for more consistent data

* extend bronze slots test to verify table lenght

* use different table names for join tables

* added back query filtering

---------

Co-authored-by: Norbert <katunanorbert@gmail.com>
@idiom-bytes
Copy link
Member

@kdetry please fill this bug w/ proper information...

@idiom-bytes
Copy link
Member

As far as I can tell, the bronze_pdr_slot table is not working at the moment.

It is currently disabled in a couple of PRs, and will likely remain so as we prepare to get duckdb-integration PR release candidate ready.

@idiom-bytes idiom-bytes mentioned this issue May 14, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdetry kdetry

Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kdetry @KatunaNorbert @idiom-bytes