Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lake][Subgraph] Clean up subgraph objects, use pydantic table objects instead. #974

Closed
3 tasks
idiom-bytes opened this issue Apr 30, 2024 · 2 comments
Closed
3 tasks

[Lake][Subgraph] Clean up subgraph objects, use pydantic table objects instead. #974

idiom-bytes opened this issue Apr 30, 2024 · 2 comments
Labels
Type: Enhancement New feature or request

Comments

@idiom-bytes
Copy link
Member

Background / motivation

Subgraph objects (Prediction, Slot, Payout, Subscription) are unnecessary and redundant.

Subgraph fetching is part of data-integration, the flow should be:

  1. to validate it
  2. save it to CSV
  3. add to duckdb-lake

Perhaps, make sure that pydantic update is in place - #973

TODOs / DoD

  • Remove redundant data objects inside subgraph
  • Utilize pydantic objects for validating data coming from subgraph
  • Update tests or anywhere else as required
@idiom-bytes idiom-bytes added the Type: Enhancement New feature or request label Apr 30, 2024
@calina-c
Copy link
Contributor

@idiom-bytes I think this can be closed, right?

@idiom-bytes
Copy link
Member Author

Yes it can, closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@calina-c @idiom-bytes