Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] sysbench-test is instability, sometimes coredump #403

Closed
nautaa opened this issue May 11, 2024 · 0 comments · Fixed by #406
Closed

[BUG] sysbench-test is instability, sometimes coredump #403

nautaa opened this issue May 11, 2024 · 0 comments · Fixed by #406
Labels
bug Something isn't working

Comments

@nautaa
Copy link
Member

nautaa commented May 11, 2024 •
edited

Describe the bug
A clear and concise description of what the bug is.
ref: https://github.com/nautaa/miniob/actions/runs/9042402084
It seems to be related to index file persistence.
** Environment**
Environment Details sometimes important

  • OS Version:
  • CPU Arch(x86/arm):
  • Compiler:
  • Others:

Fast Reproduce Steps(Required)
Steps to reproduce the behavior:

  1. set sysbench table_size = 100; // relatively small
  2. run sysbench miniob_select prepare
  3. run sysbench miniob_select run
  4. killall observer
  5. restart observer
    ref: https://github.com/oceanbase/miniob/compare/main...nautaa:miniob:test_sysbench_2?expand=1

Expected behavior
A clear and concise description of what you expected to happen.

Actual Behavior
What is the result? picture is allowed

Additional context
Add any other context about the problem here.
@nautaa nautaa added the bug Something isn't working label May 11, 2024
@nautaa nautaa changed the title [BUG] sysbench-test is instability, sometimes coredump with -DENABLE_ASAN=OFF [BUG] sysbench-test is instability, sometimes coredump May 13, 2024
@hnwyllmm hnwyllmm mentioned this issue May 14, 2024
Merged
hnwyllmm added a commit that referenced this issue May 14, 2024
@hnwyllmm
[double write buffer]write page into file in add_page (#406)
fb73701 
### What problem were solved in this pull request?

Issue Number: close #403

Problem:
当更新double write buffer中的页面时，数据没有写入到磁盘，导致下次在读取时，数据不是最新的。

### What is changed and how it works?
在调用add_page时，也刷新文件到磁盘。
double write buffer 增加设计要求：保证内存和磁盘中的数据都是最新的，比buffer pool中的要新。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[double write buffer]write page into file in add_page hnwyllmm/miniob
1 participant
@nautaa