Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppx_interact is not compatible with OCaml 5.2 #25855

Merged
merged 1 commit into from May 12, 2024
Merged

Conversation

kit-ty-kate
Copy link
Member

uses Misc.find_in_path_uncap from compiler-libs.
Reported upstream in dariusf/ppx_interact#2 cc @dariusf

#=== ERROR while compiling ppx_interact.0.1.0 =================================#
# context              2.2.0~beta3~dev | linux/x86_64 | ocaml-variants.5.2.0+trunk | file:///home/opam/opam-repository
# path                 ~/.opam/5.2/.opam-switch/build/ppx_interact.0.1.0
# command              ~/.opam/5.2/bin/dune build -p ppx_interact -j 1 @install
# exit-code            1
# env-file             ~/.opam/log/ppx_interact-20-241059.env
# output-file          ~/.opam/log/ppx_interact-20-241059.out
### output ###
# (cd _build/default && /home/opam/.opam/5.2/bin/ocamlc.opt -w -40 -g -bin-annot -I runtime/.ppx_interact_runtime.objs/byte -I /home/opam/.opam/5.2/lib/linenoise -I /home/opam/.opam/5.2/lib/ocaml/compiler-libs -I /home/opam/.opam/5.2/lib/ocaml/unix -no-alias-deps -o runtime/.ppx_interact_runtime.objs/byte/ppx_interact_runtime.cmo -c -impl runtime/ppx_interact_runtime.ml)
# File "runtime/ppx_interact_runtime.ml", line 215, characters 8-31:
# 215 |     try Misc.find_in_path_uncap search_path (unit ^ ".cmt")
#               ^^^^^^^^^^^^^^^^^^^^^^^
# Error: Unbound value "Misc.find_in_path_uncap"

@dariusf
Copy link
Contributor

dariusf commented May 11, 2024

Thanks, I've made a new release (#25862).

@avsm avsm merged commit 739cf1c into ocaml:master May 12, 2024
2 checks passed
@avsm
Copy link
Member

avsm commented May 12, 2024

and new released merged as well. Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants