Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches are configured with OCAML_TOPLEVEL_PATH but the variable name is OCAMLTOP_INCLUDE_PATH #25819

Open
dbuenzli opened this issue May 8, 2024 · 1 comment
Assignees

Comments

@dbuenzli
Copy link
Collaborator

dbuenzli commented May 8, 2024

I was trying to change omod and down to stop pooping omod.top and down.top into ocaml's library directory and leave it for $(opam var lib)/toplevel to handle it.

This should be possible since OCaml 4.08.0 when ocaml/ocaml#7808 was resolved by @nojb's ocaml/ocaml#1841.

Unfortunately the compilers packages set the OCAML_TOPLEVEL_PATH instead of OCAMLTOP_INCLUDE_PATH so that doesn't work.

Not sure exactly who's responsible for opam compiler packages so I tentatively cc @Octachron and @dra27.

# With a down modified to no longer install `down.top` in $(opam var lib:ocaml)

> OCAML_TOPLEVEL_PATH=/Users/dbuenzli/.opam/4.14.2/lib/toplevel ocaml -noinit 
OCaml version 4.14.2
Enter #help;; for help.

# #use "down.top";;
Cannot find file down.top.
# ^D
> OCAMLTOP_INCLUDE_PATH=/Users/dbuenzli/.opam/4.14.2/lib/toplevel ocaml -noinit
OCaml version 4.14.2
Enter #help;; for help.

# #use "down.top";;
Down v0.3.0-5-g8eef77b loaded. Type Down.help () for more info.
# 
dbuenzli added a commit to dbuenzli/opam-repo-ocamlnat that referenced this issue May 8, 2024
dbuenzli added a commit to dbuenzli/down that referenced this issue May 8, 2024
This reverts commit b2d98ea.

We can't do that before opam switches are configured
correctly see:

ocaml/opam-repository#25819
@dra27
Copy link
Member

dra27 commented May 9, 2024

Not sure exactly who's responsible for opam compiler packages so I tentatively cc @Octachron and @dra27.

Suggests that I really should move on getting the precise value in dra27@7813e70 sorted out and upstreamed 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants