Release v0.17 of Core and dependencies

[dkalinichenko-js]

This PR contains the latest release of Jane Street's Core and necessary dependencies.

[dkalinichenko-js]

Seems like many packages have errors due to the deprecated Caml module. I will add version bounds to them.

[dkalinichenko-js]

I see there are still a bunch of errors related to Caml, will fix.

[mbarbin]

Hello @dkalinichenko-js,

I wanted to mention to you in case this is useful information, as I was trying different combinations of core and ocaml versions I noticed that core.v0.17.0 doesn't build with ocaml.5.2.0.

File "core/src/gc.ml", line 581, characters 6-8:
581 |     | () ->
            ^^
Error: This pattern matches values of type unit/2
       but a pattern was expected which matches values of type
         Stdlib.Gc.Memprof.t
       File "_none_", line 1:
         Definition of type unit/2

Looks like it is due to an Experimental API change in ocaml/ocaml#12381 the function Stdlib.Gc.Memprof.start now returns a t rather than unit.

As it stands, it seems you would need to constraint core.v0.17.0 to 5.1 only.

It's possible there's a quick fix that makes the pattern permit the type t (perhaps a version dependent preprocess or something), but looking into the function measure_and_log_allocation_local as a whole, it seems there might be a more subtle story with respect to multicore runtime. I'll defer to you on that.

I'm interested to know if you plan for having a core.v0.17.* that's compatible with 5.2 or, if you think it'll likely to await v0.18.*.

Thanks!

[dkalinichenko-js]

Hi! We definitely want v0.17 of our libraries to be available with OCaml 5.2. I'll look into the problem after finishing releasing all packages and will submit Core v0.17.1 if there's a fix.

[mbarbin]

Great! Thanks for letting me know, and good luck with the release.

[mseri]

Should we add an upper bound on ocaml5.2 to core v0.17?

This PR is huge. @dkalinichenko-js would it be possible to move the upper bounds on third party packages to a separate PR? I can merge that straight away, then we can add the bounds to core here and have an easier time with the review

[dkalinichenko-js]

Done, see #25888. I also added an upper bound to Core.

Based on the previous CI run, I think all remaining failures are unrelated to this release.

[mseri]

Thanks. d87bb8f slipped in, I made a new PR without it (#25898) and merged it.

If update this one with just d87bb8f and 264b360 I think it is ready for review

[dkalinichenko-js]

Done, though one commit adding version bounds still got left out of the previous PR.

[mseri]

Thanks for spotting it!

[mseri]

Besides the CI issues, there are a few failures I would like to look at before merging. I’m traveling and have bad internet these days, but I should be able to do it on Thursday

[mseri]

Is this failure in qucheck-core 0.20--0.21.3 related to the new release?

#=== ERROR while compiling qcheck-core.0.21.3 =================================#
# context              2.2.0~beta3~dev | linux/x86_64 | ocaml-base-compiler.5.2.0 | file:///home/opam/opam-repository
# path                 ~/.opam/5.2/.opam-switch/build/qcheck-core.0.21.3
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p qcheck-core -j 39
# exit-code            1
# env-file             ~/.opam/log/qcheck-core-7-527038.env
# output-file          ~/.opam/log/qcheck-core-7-527038.out
### output ###
# (cd _build/default && /home/opam/.opam/5.2/bin/ocamlc.opt -w -40 -g -bin-annot -I test/core/.QCheck_unit_tests.eobjs/byte -I /home/opam/.opam/5.2/lib/alcotest -I /home/opam/.opam/5.2/lib/astring -I /home/opam/.opam/5.2/lib/bytes -I /home/opam/.opam/5.2/lib/cmdliner -I /home/opam/.opam/5.2/lib/fmt -I /home/opam/.opam/5.2/lib/ocaml/unix -I /home/opam/.opam/5.2/lib/re -I /home/opam/.opam/5.2/lib/seq -I /home/opam/.opam/5.2/lib/stdlib-shims -I /home/opam/.opam/5.2/lib/uuidm -I src/core/.qcheck_core.objs/byte -no-alias-deps -open Dune__exe -o test/core/.QCheck_unit_tests.eobjs/byte/dune__exe__QCheck2_unit_tests.cmo -c -impl test/core/QCheck2_unit_tests.ml)
# File "test/core/QCheck2_unit_tests.ml", line 23, characters 14-20:
# 23 |     Alcotest.(check' (list int))
#                    ^^^^^^
# Error: Unbound value "check'"
# Hint: Did you mean "check"?
# File "test/core/dune", line 60, characters 9-26:
# 60 |   (names QCheck_unit_tests QCheck2_unit_tests)
#               ^^^^^^^^^^^^^^^^^
# (cd _build/default/test/core && ./QCheck_unit_tests.exe)
# Error: "Test.make ~long_factor" is not a valid test label (must match ^[a-zA-Z0-9_- ]+$).
# Error: "Test.make ~count" is not a valid test label (must match ^[a-zA-Z0-9_- ]+$).

Is this also related to this release?

#=== ERROR while compiling ocplib-simplex.0.3 =================================#
# context              2.2.0~beta3~dev | linux/x86_64 | ocaml-base-compiler.5.2.0 | file:///home/opam/opam-repository
# path                 ~/.opam/5.2/.opam-switch/build/ocplib-simplex.0.3
# command              ~/.opam/opam-init/hooks/sandbox.sh build make
# exit-code            2
# env-file             ~/.opam/log/ocplib-simplex-7-fbb5e2.env
# output-file          ~/.opam/log/ocplib-simplex-7-fbb5e2.out
### output ###
# cp src/extSigs.mli src/extSigs.ml
# cp src/coreSig.mli src/coreSig.ml
# ocamldep -I src src/*.ml* > .depend
# ocamlc.opt -c -annot -absname -bin-annot -short-paths -strict-sequence -w +A -g -I src -for-pack OcplibSimplex src/version.mli
# ocamlc.opt -c -annot -absname -bin-annot -short-paths -strict-sequence -w +A -g -I src -for-pack OcplibSimplex src/version.ml
# ocamlc.opt -c -annot -absname -bin-annot -short-paths -strict-sequence -w +A -g -I src -for-pack OcplibSimplex src/extSigs.mli
# ocamlc.opt -c -annot -absname -bin-annot -short-paths -strict-sequence -w +A -g -I src -for-pack OcplibSimplex src/rat2.mli
# ocamlc.opt -c -annot -absname -bin-annot -short-paths -strict-sequence -w +A -g -I src -for-pack OcplibSimplex src/rat2.ml
# ocamlc.opt -c -annot -absname -bin-annot -short-paths -strict-sequence -w +A -g -I src -for-pack OcplibSimplex src/extSigs.ml
# ocamlc.opt -c -annot -absname -bin-annot -short-paths -strict-sequence -w +A -g -I src -for-pack OcplibSimplex src/polys.mli
# ocamlc.opt -c -annot -absname -bin-annot -short-paths -strict-sequence -w +A -g -I src -for-pack OcplibSimplex src/polys.ml
# ocamlc.opt -c -annot -absname -bin-annot -short-paths -strict-sequence -w +A -g -I src -for-pack OcplibSimplex src/coreSig.mli
# ocamlc.opt -c -annot -absname -bin-annot -short-paths -strict-sequence -w +A -g -I src -for-pack OcplibSimplex src/coreSig.ml
# ocamlc.opt -c -annot -absname -bin-annot -short-paths -strict-sequence -w +A -g -I src -for-pack OcplibSimplex src/core.mli
# ocamlc.opt -c -annot -absname -bin-annot -short-paths -strict-sequence -w +A -g -I src -for-pack OcplibSimplex src/core.ml
# File "/home/opam/.opam/5.2/.opam-switch/build/ocplib-simplex.0.3/src/core.ml", line 231, characters 14-75:
# 231 |               "%a   [ %a == (%4a , %4a) ]   %a   (computed %s) (flag %s)@."
#                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: invalid format "%a   [ %a == (%4a , %4a) ]   %a   (computed %s) (flag %s)@.": at character number 20, `padding' is incompatible with 'a' in sub-format "%4a"
# make: *** [Makefile:130: src/core.cmo] Error 2

[mseri]

The rest seems fine (or unrelated and fixed in a separate PR that I am submitting now)

[dkalinichenko-js]

As far as I can tell, the first failure you linked is caused by alcotest, not our packages.

[dkalinichenko-js]

ocplib-simplex also does not depend on our packages.

[mseri]

The first part yes, it was this my doubt:

File "test/core/dune", line 60, characters 9-26:
# 60 |   (names QCheck_unit_tests QCheck2_unit_tests)
#               ^^^^^^^^^^^^^^^^^
# (cd _build/default/test/core && ./QCheck_unit_tests.exe)
# Error: "Test.make ~long_factor" is not a valid test label (must match ^[a-zA-Z0-9_- ]+$).
# Error: "Test.make ~count" is not a valid test label (must match ^[a-zA-Z0-9_- ]+$).

[dkalinichenko-js]

Just checked, qcheck-core also does not depend on our packages.

[mseri]

Thanks for checking!

[mseri]

And for the release