Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title splicing problems on master #941

Closed
dbuenzli opened this issue Mar 29, 2023 · 1 comment · Fixed by #1116
Closed

Title splicing problems on master #941

dbuenzli opened this issue Mar 29, 2023 · 1 comment · Fixed by #1116
Labels
bug Something isn't working cross-referencer output

Comments

@dbuenzli
Copy link
Contributor

It seems that when we fully qualify a section reference (or make one from another module) the title does not get spliced.

> cat bla.mli 
(** {2:splice_me Splice me}

    This is correct {!splice_me}.

    This is incorrect {!Bla.splice_me}. *)

Screenshot 2023-03-29 at 09 17 43

Not sure whether it's regression or not.
@dbuenzli dbuenzli added bug Something isn't working output cross-referencer labels Mar 29, 2023
@gpetiot gpetiot mentioned this issue Mar 29, 2023
Closed
@Julow
Copy link
Collaborator

Julow commented Mar 30, 2023

Related issue that might have the same fix: #779

panglesd added a commit to panglesd/odoc that referenced this issue Apr 19, 2024
@panglesd
Add test for text in referenced label (issue ocaml#941)
2460bc9 
Signed-off-by: Paul-Elliot <peada@free.fr>
@panglesd panglesd mentioned this issue Apr 19, 2024
Merged
panglesd added a commit to panglesd/odoc that referenced this issue May 6, 2024
@panglesd
Add test for text in referenced label (issue ocaml#941)
6378ab9 
Signed-off-by: Paul-Elliot <peada@free.fr>
jonludlam pushed a commit that referenced this issue May 22, 2024
@panglesd @jonludlam
Add test for text in referenced label (issue #941)
b2fa565 
Signed-off-by: Paul-Elliot <peada@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cross-referencer output
Projects
None yet
Milestone
No milestone
2 participants
@dbuenzli @Julow