Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Data) Extend the Data Model of Academic Institution to Record Information about Course Materials #2328

Open
sabine opened this issue Apr 9, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted

Comments

@sabine
Copy link
Collaborator

sabine commented Apr 9, 2024

In the Wireframes for the improved "Teaching and Research" page (formerly "Academic Users"), we list course materials from lectures.

To make this truly useful, we need to improve the data model in academic_institution.ml:

  1. Add a field year : int option to course, so that we can sort the courses by most recent.
  2. Add a field lecture_notes_available: bool option to represent whether lecture notes can be found at the URL pointed to by the field online_resource
  3. Similarly, add a field exercises_available: exercise_availability option where type exercise_availability = Yes | Interactive (where Yes maps to the string "yes", and Interactive maps to the string "interactive") to represent whether there are exercises provided at the URL pointed to by the field online_resource.

To make this data available in the templates, you need to change data.mli and render the new fields to the generated module in academic_institution.ml.

The task here is only to change the data model and maybe update one data entry (as to keep the PR small).

@sabine sabine added data help wanted enhancement New feature or request good first issue Good for newcomers and removed data labels Apr 9, 2024
@0xSaksham
Copy link

Hi Sabine, I'd like to take up this issue. What are the language requirements for this?

@sabine
Copy link
Collaborator Author

sabine commented Apr 9, 2024

Hey @0xSaksham, would be happy to have you! This issue is all about making changes to OCaml code.

To confirm that the data is available to the templates, you might want to try and render the data to the the EML template academic_users.eml (this file format is a mix of OCaml and HTML). Implementing the UI will be a separate issue later, when the design is finalized.

@maha-sachin
Copy link
Contributor

hi @sabine, I'd like to work on this issue.

@csaltachin
Copy link
Contributor

Hi, I can pick this up if it's still open. Looks like there's no extra decoding logic here for now.

Is there currently a Dream route serving the academic_users.eml template? Just so I can check that the template hydrates correctly with the new course fields.

@sabine
Copy link
Collaborator Author

sabine commented May 17, 2024

Hey @csaltachin! Yes, there's a route at https://ocaml.org/academic-users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants