Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn exercise 003 into practice #2187

Closed
wants to merge 4 commits into from
Closed

Turn exercise 003 into practice #2187

wants to merge 4 commits into from

Conversation

mnaibei
Copy link
Contributor

@mnaibei mnaibei commented Mar 13, 2024 •
edited by cuihtlauac

This PR is in reference to task #2167

I am still confused if this is the proper implementation based on task description, I would appreciate detailed feedback on my attempt if possible @SaySayo @cuihtlauac

PS I wanted this to be a draft PR but I forgot to change that, please consider it DRAFT

Fix Issue #2167

@mnaibei mnaibei changed the title Turn exercise 003 into practice DRAFT: Turn exercise 003 into practice Mar 13, 2024
@cuihtlauac
Copy link
Collaborator

Thanks @mnaibei, you are doing well

  • You are missing file dune in folders work/test and answer/test
  • Several files are missing newline at end of file
  • The following commands must execute successfully:
    • dune built --root .
    • dune test --root answer

@cuihtlauac cuihtlauac added the outreachy Outreachy contributions and blog posts label Mar 14, 2024
@cuihtlauac cuihtlauac changed the title DRAFT: Turn exercise 003 into practice Turn exercise 003 into practice Mar 14, 2024
cuihtlauac
cuihtlauac requested changes Mar 14, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
practice/003/answer/impl.ml Show resolved Hide resolved
practice/003/work/impl.ml Show resolved Hide resolved
@cuihtlauac cuihtlauac linked an issue Mar 14, 2024 that may be closed by this pull request
Turn exercise 003 into practice #2167
Open
@mnaibei
Copy link
Contributor Author

mnaibei commented Mar 14, 2024 •
edited

Hi @cuihtlauac in my local file I have put in the required EOF newline but once pushed the newline is removed🤔., could you advise me on how to prevent this?

here is a screenshot of one of the files:
Screenshot 2024-03-14 at 18 51 00

cuihtlauac
cuihtlauac requested changes Mar 18, 2024
View reviewed changes
.gitignore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not modify this file in this PR

@mnaibei mnaibei closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuihtlauac cuihtlauac cuihtlauac requested changes

Assignees
No one assigned
Labels
outreachy Outreachy contributions and blog posts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn exercise 003 into practice
2 participants
@mnaibei @cuihtlauac